Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Davicom DM9051 SPI Ethernet Controller #3914

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Conversation

bmork
Copy link

@bmork bmork commented Jun 4, 2024

with ETH01-Evo config example.

Description:

Pull request in esphome with YAML changes (if applicable): esphome/esphome#6861

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 4ced5e9
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/66ffba442291080008956c5e
😎 Deploy Preview https://deploy-preview-3914--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bmork bmork force-pushed the dm9051 branch 2 times, most recently from 9844530 to a901ec0 Compare June 4, 2024 18:05
Copy link

github-actions bot commented Aug 4, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 4, 2024
@bmork
Copy link
Author

bmork commented Aug 4, 2024

The automatic stale labelling is a bit too agressive considering to the review lag in core... Still waiting for some/any feedback

Copy link

github-actions bot commented Oct 4, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 4, 2024
@bmork
Copy link
Author

bmork commented Oct 4, 2024

Well. Status is still the same. The PR is ready for merge AFAIK. But review is slow. Don't know if there's anything that can be done about that?

@nagyrobi
Copy link
Member

nagyrobi commented Oct 4, 2024

Resolve conflicts?

@nagyrobi nagyrobi added not-stale and removed stale labels Oct 4, 2024
with ETH01-Evo config example.

Signed-off-by: Bjørn Mork <bjorn@mork.no>
@bmork
Copy link
Author

bmork commented Oct 4, 2024

Resolve conflicts?

Right. Good point. I completely missed that even if I recently updated the code PR. Fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants