Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation for idle mode for SPS30 sensor #3913

Closed
wants to merge 13 commits into from

Conversation

c0mputerguru
Copy link

Description:

Adding documentation for idle mode for SPS30 sensor.

Related issue (if applicable): fixes esphome/feature-requests#2133

Pull request in esphome with YAML changes (if applicable): esphome/esphome#6828

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

saibotma and others added 13 commits June 2, 2024 22:55
* Set SN74HC165's clock_inhibit_pin as optional

The use of only 3 pins is mentioned, but the configuration values don't reflect that.
Datasheet specifies the pin can be directly connected to ground. The code already expects the pin to not be used: https://github.com/esphome/esphome/blob/ec3162282cd5a2c3455dd7a8669b4f762c481a20/esphome/components/sn74hc165/__init__.py#L35

* Update sn74hc165.rst

* Update sn74hc165.rst

---------

Co-authored-by: H. Árkosi Róbert <robreg@zsurob.hu>
… usage (esphome#3723)

Co-authored-by: H. Árkosi Róbert <robreg@zsurob.hu>
Update to the Addressable Color Wipe Example to correctly include gradient as an option of the color rather than the entire effect
Co-authored-by: H. Árkosi Róbert <robreg@zsurob.hu>
* doc: wifi reboot_timeout disabled if ap enabled

* Update wifi.rst

* Update wifi.rst

---------

Co-authored-by: H. Árkosi Róbert <robreg@zsurob.hu>
…e#3771)

It's probably clear to most people that setting up a trigger for the 31st of every month will fail in February, but apparently triggers between 1am and 3am are also fragile once a year. For non-disruptive or regular triggers, this might not be an issue -- if you want to turn off a device at 2am using on_time, you should know that it will fail once a week. Similarly, if you want to do a daily trigger at 1am, you should know that it will trigger twice a day once a year. 

This does not seem super-obvious until you've run into it, so I propose adding a note to the documentation. It also doesn't feel like something that should be changed in the functionality to match cron's behavior, given that it would change the functionality of existing triggers. 

I'm not invested in the exact wording / location; I suspect pulling it out a bit into a more visible place makes it less likely for people to miss.

(Brought to you by a trigger that turns off an expensive device at 2am, only for it to run a full day instead :-)).
This Example has previously not been referenced and had been misplaced at the top of the variants.
* Improve SGP30 compensation documentation

* Use must instead of should, fix celsius spelling
…#3446)

* Add Seeed Studio XIAO ESP32S3 Sense pins to esp32_camera.rst

Added camera pin configuration for Seeed Studio XIAO ESP32S3 Sense to Camera page

* Added missing blank line

* Update esp32_camera.rst

---------

Co-authored-by: H. Árkosi Róbert <robreg@zsurob.hu>
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 2973e99
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/665f45232743b00008a2f71d
😎 Deploy Preview https://deploy-preview-3913--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Aug 4, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 4, 2024
@c0mputerguru
Copy link
Author

c0mputerguru commented Aug 4, 2024 via email

@github-actions github-actions bot removed the stale label Aug 5, 2024
Copy link

github-actions bot commented Oct 4, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 4, 2024
@github-actions github-actions bot closed this Oct 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.