Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note about alternative wind sensors due to deprecation by manufacturer #3869

Merged
merged 10 commits into from
Jul 2, 2024

Conversation

nagyrobi
Copy link
Member

@nagyrobi nagyrobi commented May 25, 2024

The TX20/TX23 model natively supported is not available for purchase for a very long time now. Contacted their distributor, who answered that the product has been discontinued.

Description:

Related issue (if applicable): fixes esphome/feature-requests#1103

Pull request in esphome with YAML changes (if applicable): esphome/esphome#

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Summary by CodeRabbit

  • Documentation
    • Updated sensor documentation to remove references to discontinued TX20/TX23 models.
    • Added information on alternative wind sensor models compatible with ESPHome's modbus component.

The TX20/TX23 model natively supported is not available for purchase for a very long time now. Contacted their distributor, who answered that the product has been discontinued.
Copy link

netlify bot commented May 25, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit ac328ab
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/6651f49d42c55300092d14f6
😎 Deploy Preview https://deploy-preview-3869--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 25, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 453da14
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/6651f4d417c58a0008d2428a
😎 Deploy Preview https://deploy-preview-3869--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 25, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 08ce8b8
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/667d1e8587d7180008a32aa2
😎 Deploy Preview https://deploy-preview-3869--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented May 28, 2024

Walkthrough

The changes in the documentation involve removing references to specific wind sensors like TX20 and TX23 due to their discontinuation. The updated documentation now suggests alternative models that are compatible with ESPHome's modbus component.

Changes

File Change Summary
components/sensor/tx20.rst Removed references to TX20/TX23 sensors, mentioned their discontinuation, and suggested alternatives compatible with ESPHome's modbus component.

In winds of change, the sensors sway,
TX20 and TX23 have had their day.
New models rise, with modbus ties,
To measure breezes under clear skies.
Embrace the new, let data flow,
With ESPHome, the winds will show.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bc91bdd and 5581dff.
Files selected for processing (1)
  • components/sensor/tx20.rst (3 hunks)
Files skipped from review due to trivial changes (1)
  • components/sensor/tx20.rst

@nagyrobi nagyrobi changed the title Add a note about alternative wind sensors Note about alternative wind sensors due to deprecation by manufacturer Jun 10, 2024
@nagyrobi
Copy link
Member Author

Updated config example in the devices site with possibility to change the device's modbus address from within ESPHome.

@nagyrobi nagyrobi added this to the 2024.6.3 milestone Jun 25, 2024
@jesserockz jesserockz merged commit 27f3440 into current Jul 2, 2024
2 checks passed
@jesserockz jesserockz deleted the nagyrobi-patch-3 branch July 2, 2024 00:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacement for TX20/TX23 Wind Speed/Direction Sensor
2 participants