-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MediaPlayerSupportedFormat #925
Add MediaPlayerSupportedFormat #925
Conversation
WalkthroughThe recent changes introduce enhancements to the media player functionality in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
@jesserockz Did I do something wrong to cause this test to fail? |
@synesthesiam I think you generated the files with a different proto version. Ill try fix |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Ok, if not I'll try to upgrade and regenerate the files tomorrow. |
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@jesserockz I have libprotoc version 3.21.12. Looks like this is too new, since the script expects 3.6.1 |
You can use docker to generate too docker run -v "$PWD":/aioesphomeapi ghcr.io/esphome/aioesphomeapi-proto-builder:latest |
Do I need to add a version bump too? |
Extends the media player info with a list of supported audio formats. This is used in Home Assistant to swap out media URLs going to the ESPHome device with proxy URLs that contain the converted audio.
Depends on the following PRs: