#2557 - ESP8266WebServer uses >2kb of stack when reinitialized in setup() #3721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR for #2557 changes the
_currentUpload
field in theESP8266WebServer
class tostd::unique_ptr<HTTPUpload>
, and allocates/deallocates it on demand.Commit 67f4fc4 eliminates most of the exit paths in
ESP8266WebServer::handleClient
. It moves the client reset andyield()
call to the end of the function, introduceselse
clauses to remove exit paths, and inverts if/else constructs to simplify the function.