Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2557 - ESP8266WebServer uses >2kb of stack when reinitialized in setup() #3721

Merged
merged 2 commits into from
Oct 22, 2017
Merged

#2557 - ESP8266WebServer uses >2kb of stack when reinitialized in setup() #3721

merged 2 commits into from
Oct 22, 2017

Conversation

chschu
Copy link
Contributor

@chschu chschu commented Oct 15, 2017

This PR for #2557 changes the _currentUpload field in the ESP8266WebServer class to std::unique_ptr<HTTPUpload>, and allocates/deallocates it on demand.

Commit 67f4fc4 eliminates most of the exit paths in ESP8266WebServer::handleClient. It moves the client reset and yield() call to the end of the function, introduces else clauses to remove exit paths, and inverts if/else constructs to simplify the function.

@igrr igrr merged commit e71ec77 into esp8266:master Oct 22, 2017
@chschu chschu deleted the bugfix/webserver_upload_memory branch November 1, 2017 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants