Remove special handling of MUSL Linux now that we no longer use libudev #749
+0
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d9eee6 to
5d52557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
serialportenumerates more ports without the use oflibudev(see serialport/serialport-rs#238), perhaps port detection will work as expected on Linux systems using MUSL without the specialized function for these platforms.Opening as a draft as I currently have no way to test this, if somebody from the community is able to verify port detection still works on Linux systems using MUSL that would very much be appreciated!
If things continue to work as expected, would be nice to get rid of this extra code. If not, no real loss I guess, and this PR can just be closed.