database: database_connection.py: handle sensitive information, closes #71 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request review checklist 📝 ✅
This is a checklist that helps conduct a pull request review properly. These points are required to merge the PR
There are no merge conflicts
The pull request is named accordingly (description of the functionality - it
will be visible in the changelog later)
Every task requirement (from Jira) is done
The app runs, it boots up properly (e.g. no syntax errors)
The proposed functionality is working properly (you need to pull this branch
and check for yourself)
Each function, class or functionality is properly documented
(short description of what it does, parameters or return values if they need
any explanation)