Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interface for saving and loading a game #206

Merged
merged 14 commits into from
Jun 19, 2023
Merged

Conversation

pcichowski
Copy link
Member

@pcichowski pcichowski commented May 17, 2023

Pull request review checklist 📝 ✅

This is a checklist that helps conduct a pull request review properly. These points are required to merge the PR

  • There are no merge conflicts

  • The pull request is named accordingly (description of the functionality - it
    will be visible in the changelog later)

  • Every task requirement (from Jira) is done

  • The app runs, it boots up properly (e.g. no syntax errors)

  • The proposed functionality is working properly (you need to pull this branch
    and check for yourself)

  • Each function, class or functionality is properly documented
    (short description of what it does, parameters or return values if they need
    any explanation)

@pcichowski pcichowski marked this pull request as draft May 17, 2023 14:40
@github-actions
Copy link

github-actions bot commented May 17, 2023

Test Results

42 tests  ±0   42 ✔️ ±0   7s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 94faf71. ± Comparison against base commit ff75632.

♻️ This comment has been updated with latest results.

@pcichowski
Copy link
Member Author

aktualny status: zapisywanie stanu gry za pomocą komendy /pause działa, okazuje się natomiast że ładowanie gry jest dość problematyczne i będzie trzeba to przemyśleć

@pcichowski pcichowski marked this pull request as ready for review June 19, 2023 16:57
@pcichowski pcichowski requested review from kapselccc and Cellmer June 19, 2023 17:01
Copy link
Contributor

@Cellmer Cellmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funkcje wymagają udokumentowania, lecz ze względu na mało czasu do prezentacji daję approve'a, ponieważ funkcjonalność działa poprawnie.

@pcichowski pcichowski merged commit 290e9a5 into staging Jun 19, 2023
@pcichowski pcichowski deleted the game-save-interface branch June 19, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants