Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogue view placeholder #199

Merged
merged 8 commits into from
May 15, 2023
Merged

Dialogue view placeholder #199

merged 8 commits into from
May 15, 2023

Conversation

gitesthuman
Copy link
Contributor

@gitesthuman gitesthuman commented May 9, 2023

Pull request review checklist 📝 ✅

This is a checklist that helps conduct a pull request review properly. These points are required to merge the PR

  • There are no merge conflicts

  • The pull request is named accordingly (description of the functionality - it
    will be visible in the changelog later)

  • Every task requirement (from Jira) is done

  • The app runs, it boots up properly (e.g. no syntax errors)

  • The proposed functionality is working properly (you need to pull this branch
    and check for yourself)

  • Each function, class or functionality is properly documented
    (short description of what it does, parameters or return values if they need
    any explanation)

@gitesthuman gitesthuman requested a review from pcichowski May 9, 2023 11:24
@github-actions
Copy link

github-actions bot commented May 9, 2023

Test Results

13 tests  ±0   13 ✔️ ±0   1s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit d13ebf4. ± Comparison against base commit e2f8eaf.

♻️ This comment has been updated with latest results.

@gitesthuman gitesthuman requested review from Mixss and Cellmer May 10, 2023 07:17
dnd-bot/dnd_bot/dc/ui/views/view_game.py Outdated Show resolved Hide resolved
@gitesthuman gitesthuman requested a review from Cellmer May 10, 2023 17:25
dnd-bot/dnd_bot/dc/ui/views/view_game.py Outdated Show resolved Hide resolved
dnd-bot/dnd_bot/logic/game/handler_dialogue.py Outdated Show resolved Hide resolved
dnd-bot/dnd_bot/logic/prototype/creature.py Show resolved Hide resolved
@Cellmer
Copy link
Contributor

Cellmer commented May 10, 2023

Generalnie piękna sprawa jak dla mnie, drobne poprawki tak jak napisałem.

Copy link
Member

@pcichowski pcichowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

Nie wybierając nikogo do pogadania wyrzucany jest błąd. Bardzo prosta poprawka polegająca na wyrzuceniu wyjątku i wypisanie jakiegoś error_dm_message

@gitesthuman gitesthuman requested review from pcichowski and Cellmer May 12, 2023 21:37
@gitesthuman gitesthuman dismissed pcichowski’s stale review May 15, 2023 14:22

Cellmer apprpved ez

@gitesthuman gitesthuman merged commit 1ff7c68 into staging May 15, 2023
@gitesthuman gitesthuman deleted the dialogue-view branch May 15, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants