Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added equipping and managing items in backpack #186

Merged
merged 15 commits into from
Apr 27, 2023
Merged

Added equipping and managing items in backpack #186

merged 15 commits into from
Apr 27, 2023

Conversation

Mixss
Copy link
Contributor

@Mixss Mixss commented Apr 15, 2023

Pull request review checklist 📝 ✅

This is a checklist that helps conduct a pull request review properly. These points are required to merge the PR

  • There are no merge conflicts

  • The pull request is named accordingly (description of the functionality - it
    will be visible in the changelog later)

  • Every task requirement (from Jira) is done

  • The app runs, it boots up properly (e.g. no syntax errors)

  • The proposed functionality is working properly (you need to pull this branch
    and check for yourself)

  • Each function, class or functionality is properly documented
    (short description of what it does, parameters or return values if they need
    any explanation)

@Mixss Mixss added the enhancement New feature or request label Apr 15, 2023
@Mixss Mixss self-assigned this Apr 15, 2023
@github-actions
Copy link

github-actions bot commented Apr 15, 2023

Test Results

13 tests  ±0   13 ✔️ ±0   2s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit f71bba2. ± Comparison against base commit 6fb8d2f.

♻️ This comment has been updated with latest results.

@Mixss Mixss marked this pull request as ready for review April 16, 2023 16:52
@pcichowski
Copy link
Member

backpack chyba powinien się inaczej sortować (alfabetycznie a nie po czasie wydropienia) - teraz jest bardzo nieczytelne z 6 itemami, co dopiero jak będzie ich więcej
image

@pcichowski
Copy link
Member

tak samo w tym selecie

dnd-bot/dnd_bot/assets/campaigns/campaign.json Outdated Show resolved Hide resolved
dnd-bot/dnd_bot/dc/ui/views/view_game.py Outdated Show resolved Hide resolved
dnd-bot/dnd_bot/logic/prototype/items/item.py Show resolved Hide resolved
@pcichowski
Copy link
Member

nie wiem jak można strzelać z łuku trzymając dodatkowo tarczę 🤣😂
image

Copy link
Member

@pcichowski pcichowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wyekwipowane przedmioty niby mają pokazane jakieś statystyki, ale w praktyce ich nie zwiększają (przyjamniej w widoku postaci)
image
image

@pcichowski pcichowski removed the enhancement New feature or request label Apr 17, 2023
@Mixss Mixss requested a review from pcichowski April 26, 2023 19:23
@Mixss
Copy link
Contributor Author

Mixss commented Apr 26, 2023

wszystko zostało zrobione po za dość sporymi elementami, które zostały wrzucone na issues. powód prosty - koniec sprintu i brak czasu, przeniesione na przyszłość a mimo wszystko fajnie by ten element był w jakimś stopniu dowieziony

@pcichowski
Copy link
Member

@Mixss należy zaadresować drobne poprawki o których wspomniałem na discordzie, po ich naprawieniu oraz zmianie nazwy PR dam approve

@Mixss Mixss changed the title Equip items Added equipping and managing items in backpack Apr 27, 2023
@Mixss Mixss merged commit 98840de into staging Apr 27, 2023
@Mixss Mixss deleted the equip-items branch April 27, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants