Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance message holder to be able to play multiple games #184

Merged
merged 5 commits into from
May 5, 2023

Conversation

Cellmer
Copy link
Contributor

@Cellmer Cellmer commented Apr 12, 2023

Pull request review checklist 📝 ✅

This is a checklist that helps conduct a pull request review properly. These points are required to merge the PR

  • There are no merge conflicts

  • The pull request is named accordingly (description of the functionality - it
    will be visible in the changelog later)

  • Every task requirement (from Jira) is done

  • The app runs, it boots up properly (e.g. no syntax errors)

  • The proposed functionality is working properly (you need to pull this branch
    and check for yourself)

  • Each function, class or functionality is properly documented
    (short description of what it does, parameters or return values if they need
    any explanation)

@Cellmer Cellmer marked this pull request as draft April 12, 2023 20:53
@github-actions
Copy link

github-actions bot commented Apr 12, 2023

Test Results

13 tests  ±0   13 ✔️ ±0   2s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 88e7225. ± Comparison against base commit 7f0eede.

♻️ This comment has been updated with latest results.

@Cellmer Cellmer requested a review from pcichowski April 13, 2023 12:15
@Cellmer Cellmer marked this pull request as ready for review April 13, 2023 12:15
@Cellmer
Copy link
Contributor Author

Cellmer commented Apr 13, 2023

Zaznaczam że zaimplementowany system narazie nie działa przy tworzeniu postaci. Tego buga naprawi następujący pull request:
#170 jednak najpierw chciałbym zmergować tego. Do testów polecam utworzyc dwie gry i zacząć je komendą start. Powinny edytować się tak jak trzeba.

@pcichowski
Copy link
Member

dalej nie działa robiąc character creation dla dwóch gier:
image
image

@Cellmer
Copy link
Contributor Author

Cellmer commented Apr 14, 2023

dalej nie działa robiąc character creation dla dwóch gier: image image

tak wiem, odsyłam do komentarza

@Cellmer
Copy link
Contributor Author

Cellmer commented May 5, 2023

Zaznaczam jeszcze raz, że aby poprawnie przetestować zaimplementowaną funkcjonalność należy utworzyć dwie lub więcej gier komendą start, przy tworzeniu postaci będzie wyskakiwał błąd którego naprawi następujący pull request #170 , którego zmerguję po tym.

@Cellmer Cellmer requested a review from gitesthuman May 5, 2023 16:14
Copy link
Contributor

@gitesthuman gitesthuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wygląda na to, że działa poprawnie. Komunikaty z gry "wyżej" pojawiają się na samym dole, za grą drugą. Ale to raczej problem na inny PR, poza tym nie znam szaleńca, który grałby w 2 gry naraz.

@Cellmer Cellmer merged commit 88baea1 into staging May 5, 2023
@Cellmer Cellmer deleted the message-holder-enhancement branch May 5, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants