Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework character creation so the text is shorter in some places #181

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

pcichowski
Copy link
Member

@pcichowski pcichowski commented Apr 10, 2023

Pull request review checklist 📝 ✅

This is a checklist that helps conduct a pull request review properly. These points are required to merge the PR

  • There are no merge conflicts

  • The pull request is named accordingly (description of the functionality - it
    will be visible in the changelog later)

  • Every task requirement (from Jira) is done

  • The app runs, it boots up properly (e.g. no syntax errors)

  • The proposed functionality is working properly (you need to pull this branch
    and check for yourself)

  • Each function, class or functionality is properly documented
    (short description of what it does, parameters or return values if they need
    any explanation)

@pcichowski pcichowski requested a review from Cellmer April 10, 2023 13:15
@github-actions
Copy link

Test Results

13 tests  ±0   13 ✔️ ±0   2s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 930c632. ± Comparison against base commit d933707.

Copy link
Contributor

@Cellmer Cellmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mnie się podoba także aprobuję

@Cellmer
Copy link
Contributor

Cellmer commented Apr 10, 2023

jeszcze nazwe można zmienić

@pcichowski pcichowski changed the title character creation: rework some of the text so that it is shorter Rework character creation so the text is shorter in some places Apr 11, 2023
@pcichowski pcichowski requested a review from Cellmer April 11, 2023 13:06
@pcichowski pcichowski merged commit 6e9d51a into staging Apr 11, 2023
@pcichowski pcichowski deleted the refactor-character-creation-ui branch April 11, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants