Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor initialize_world.py to be more concise #175

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

pcichowski
Copy link
Member

@pcichowski pcichowski commented Apr 4, 2023

Pull request review checklist 📝 ✅

This is a checklist that helps conduct a pull request review properly. These points are required to merge the PR

  • There are no merge conflicts

  • The pull request is named accordingly (description of the functionality - it
    will be visible in the changelog later)

  • Every task requirement (from Jira) is done

  • The app runs, it boots up properly (e.g. no syntax errors)

  • The proposed functionality is working properly (you need to pull this branch
    and check for yourself)

  • Each function, class or functionality is properly documented
    (short description of what it does, parameters or return values if they need
    any explanation)

@pcichowski pcichowski requested a review from Cellmer April 4, 2023 11:39
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Test Results

13 tests  ±0   13 ✔️ ±0   2s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 6a7d6a8. ± Comparison against base commit af1146f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Cellmer Cellmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM jak to mówią

@Cellmer
Copy link
Contributor

Cellmer commented Apr 4, 2023

ewentualnie można zmienić nazwę pull requesta i udokumentować funkcję add_entity choć nie było to akurat zadaniem tego konkretnego pull requesta

@pcichowski pcichowski changed the title game: initialize_world.py: rework entity spawning refactor initialize_world.py to be more concise Apr 4, 2023
@pcichowski pcichowski merged commit 876d5a6 into staging Apr 4, 2023
@pcichowski pcichowski deleted the rework-initialize-world branch April 4, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants