Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Game.get_attackable_enemies_for_player() #150

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

Mixss
Copy link
Contributor

@Mixss Mixss commented Mar 14, 2023

Pull request review checklist πŸ“ βœ…

This is a checklist that helps conduct a pull request review properly. These points are required to merge the PR

  • There are no merge conflicts

  • The pull request is named accordingly (description of the functionality - it
    will be visible in the changelog later)

  • Every task requirement (from Jira) is done

  • The app runs, it boots up properly (e.g. no syntax errors)

  • The proposed functionality is working properly (you need to pull this branch
    and check for yourself)

  • Each function, class or functionality is properly documented
    (short description of what it does, parameters or return values if they need
    any explanation)

@Mixss Mixss changed the title fixed attack view when there is no enemies to attack Implement Game.get_attackable_enemies_for_player() Mar 14, 2023
@github-actions
Copy link

github-actions bot commented Mar 14, 2023

Test Results

13 tests  Β±0   13 βœ”οΈ Β±0   1s ⏱️ -1s
βŸβ€„1 suites Β±0β€‚β€ƒβ€ƒβŸβ€„0 πŸ’€ Β±0 
βŸβ€„1 files   Β±0β€‚β€ƒβ€ƒβŸβ€„0 ❌ Β±0 

Results for commit b18e69b. ± Comparison against base commit 9120228.

♻️ This comment has been updated with latest results.

@Mixss Mixss marked this pull request as ready for review March 15, 2023 18:37
@Mixss Mixss requested a review from gitesthuman March 15, 2023 18:38
@Mixss Mixss merged commit db3cea8 into staging Mar 15, 2023
@Mixss Mixss deleted the get-attackable-enemies branch March 15, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants