Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character creation #135

Merged
merged 30 commits into from
Mar 12, 2023
Merged

Character creation #135

merged 30 commits into from
Mar 12, 2023

Conversation

Cellmer
Copy link
Contributor

@Cellmer Cellmer commented Mar 6, 2023

Pull request review checklist 📝 ✅

This is a checklist that helps conduct a pull request review properly. These points are required to merge the PR

  • There are no merge conflicts

  • The pull request is named accordingly (description of the functionality - it
    will be visible in the changelog later)

  • Every task requirement (from Jira) is done

  • The app runs, it boots up properly (e.g. no syntax errors)

  • The proposed functionality is working properly (you need to pull this branch
    and check for yourself)

  • Each function, class or functionality is properly documented
    (short description of what it does, parameters or return values if they need
    any explanation)

@Cellmer Cellmer marked this pull request as draft March 6, 2023 21:34
@pcichowski
Copy link
Member

@Cellmer znalazłem taki obrazek opisujący alignment, może się przyda
alignment-chart

Copy link
Member

@pcichowski pcichowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cellmer dodałem na razie tylko sugestie drobnych poprawek do tekścików

dnd-bot/dnd_bot/dc/ui/views/view_character_creation.py Outdated Show resolved Hide resolved
dnd-bot/dnd_bot/dc/ui/views/view_character_creation.py Outdated Show resolved Hide resolved
dnd-bot/dnd_bot/dc/ui/views/view_character_creation.py Outdated Show resolved Hide resolved

lawfulness_option1 = nextcord.SelectOption(
label="Lawful",
description="You're honorable man and you like to follow the rules.",
Copy link
Member

@pcichowski pcichowski Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description="You're honorable man and you like to follow the rules.",
description="You're an honorable person and you like to follow the rules.",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

laski też mogą w grać w tą grę, bądźmy poprawni politycznie 🤨

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Nie mieści się wtedy, a nie wiem jak zrobić żeby się zawijał tekst, nie znalazłem takiej opcji póki co.

dnd-bot/dnd_bot/dc/ui/views/view_character_creation.py Outdated Show resolved Hide resolved
dnd-bot/dnd_bot/dc/ui/views/view_character_creation.py Outdated Show resolved Hide resolved
Cellmer and others added 7 commits March 11, 2023 12:30
Co-authored-by: Paweł Cichowski <81694867+Silentsky0@users.noreply.github.com>
Co-authored-by: Paweł Cichowski <81694867+Silentsky0@users.noreply.github.com>
Co-authored-by: Paweł Cichowski <81694867+Silentsky0@users.noreply.github.com>
Co-authored-by: Paweł Cichowski <81694867+Silentsky0@users.noreply.github.com>
Co-authored-by: Paweł Cichowski <81694867+Silentsky0@users.noreply.github.com>
…ms in order for user being obligated to choose something
@Cellmer Cellmer requested a review from pcichowski March 11, 2023 16:56
@Cellmer Cellmer marked this pull request as ready for review March 11, 2023 16:57
@Cellmer Cellmer marked this pull request as draft March 11, 2023 20:25
@Cellmer Cellmer marked this pull request as ready for review March 12, 2023 13:02
Copy link
Member

@pcichowski pcichowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bardzo dobrze wykonane zadanie

@pcichowski
Copy link
Member

@Cellmer trzeba jeszcze naprawić konfilkty

@Cellmer Cellmer merged commit 85cb5cf into staging Mar 12, 2023
@Cellmer Cellmer deleted the character_creation branch March 12, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants