Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving game state to the database #133

Merged
merged 26 commits into from
Mar 12, 2023
Merged

Saving game state to the database #133

merged 26 commits into from
Mar 12, 2023

Conversation

kapselccc
Copy link
Contributor

@kapselccc kapselccc commented Mar 1, 2023

Pull request review checklist 📝 ✅

This is a checklist that helps conduct a pull request review properly. These points are required to merge the PR

  • There are no merge conflicts

  • The pull request is named accordingly (description of the functionality - it
    will be visible in the changelog later)

  • Every task requirement (from Jira) is done

  • The app runs, it boots up properly (e.g. no syntax errors)

  • The proposed functionality is working properly (you need to pull this branch
    and check for yourself)

  • Each function, class or functionality is properly documented
    (short description of what it does, parameters or return values if they need
    any explanation)

@kapselccc kapselccc marked this pull request as draft March 1, 2023 20:03
@kapselccc kapselccc marked this pull request as ready for review March 11, 2023 12:06
@kapselccc kapselccc requested a review from Mixss March 11, 2023 12:07
@kapselccc kapselccc force-pushed the saving_state_to_db branch from 6deeb78 to 32b3b2b Compare March 11, 2023 13:30
@kapselccc kapselccc requested review from pcichowski and removed request for Mixss March 11, 2023 15:54
@kapselccc
Copy link
Contributor Author

kapselccc commented Mar 11, 2023

Przez to że przy inicjalizacji świat wszystkie enities są ładowane do bazy danych jest opóźnienie. Myśle że dla każdej transakcji trzeba będzie tworzyć wątek i to pomoże. Myślę jednak że optymalizację można zostawić na później. A najpierw zaimplementować updatowanie stanu i wczytywanie.

Copy link
Member

@pcichowski pcichowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

działa i wygląda dobrze

@kapselccc kapselccc merged commit b3f62f2 into staging Mar 12, 2023
@pcichowski pcichowski deleted the saving_state_to_db branch April 8, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants