Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 26b: declutter webform ingest #57

Merged
merged 7 commits into from
Jul 14, 2020
Merged

Issue 26b: declutter webform ingest #57

merged 7 commits into from
Jul 14, 2020

Conversation

DiegoPino
Copy link
Member

As always this is moving #26 forward.

  • Hide Save/Moderation State in every multistep widget (except raw) we provide and make JQuery selects more precise
  • Make sure it shows back when needed!
  • Attach JS library directly on the normal webform widget (the one that is not inline) just in case form alter/JS does not work via ajax. There is a back and forth in D8/9 core about the issue so better to be safe

@DiegoPino DiegoPino self-assigned this Jul 14, 2020
@DiegoPino DiegoPino added enhancement New feature or request Javascript Because they got 'includes' a few years ago UI/UX The thing people do when in front of a screen Webform Elements Things with input to fill and interact with while ingesting metadata Webform Widgets Connecting Webforms and Entity Fields labels Jul 14, 2020
This is a response to a detail that bothers me:
When you search for a place and then select, the option you selected sticks during the whole session. Let's say selection has 4 results and you select number 4, if you search again, the selected option is again number 4, independently that this is another place in earth. Things get serious when the response has only one! In that case you can no longer select anything because its already selected. I need to double check if i will have to also modify the user input here or not
I knew i had to mangle with the user input. Damn table selects!
@DiegoPino DiegoPino merged commit 0c1926b into 8.x-1.0-beta3 Jul 14, 2020
@DiegoPino DiegoPino deleted the ISSUE-26b branch July 14, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Javascript Because they got 'includes' a few years ago UI/UX The thing people do when in front of a screen Webform Elements Things with input to fill and interact with while ingesting metadata Webform Widgets Connecting Webforms and Entity Fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant