ISSUE-171: levenshtein sorting Input v/s result labels (not description) #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes some assumptions about number of results needed for VIAF and WIKIDATA
Might interfere with #169 so testing is required on all Vocabs
|
Testing requires clearing caches, bc we cache LoD results |
|
This is working well in my local testing @DiegoPino. Seems like I'm seeing the biggest improvement in the Getty lookups, also noticing sorting improvement for LC terms as well. |
|
Thanks for your feedback and prompt testing @alliomeria |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #171 but also #169
@alliomeria on your radar please