-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: use blocksCache instead of single blocks instance (fixes #181) #183
Conversation
This issue will only occur when integrating with other plugins like Here is the fake version for testing. |
Thanks to your discussion in #181 and https://github.com/eslint/eslint/pull/14227/files#r602802758, we can reproduce this in a test without stubbing another mdx plugin! So let's simplify this:
With that as the test input, if you configure the CLIEngine to run this plugin's processor on If that doesn't work, mention me and I'll see if I can put together a reproduction case that you can use to prove this implementation works. I'm glad you were able to fix this by keying the blocks cache on the filename. There are two implementation tweaks that I'd like to request:
|
pass through lint messages from other plugins
remove unnecessary mdx example
@btmills All done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working so hard to get this down to just the essential components! I'm really happy with where it ended up. LGTM.
@btmills Any schedule for a release then? |
pass through lint messages from other plugins
close #181
split part of #178
@btmills