Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add esN envs for all post-es6 years #68

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Feb 7, 2022

@aladdin-add
Copy link
Member

should also add es3, es5?

@ljharb
Copy link
Contributor Author

ljharb commented Feb 7, 2022

@aladdin-add i'd love to, and i'd use them :-) but i didn't want to overshoot the scope of the PR.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

conf/environments.js Outdated Show resolved Hide resolved
conf/environments.js Outdated Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Waiting for a consensus on the original issue.

@nzakas nzakas merged commit 33b8ee7 into eslint:main Feb 8, 2022
@ljharb ljharb deleted the all-envs branch February 8, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Environment key "es2022" is unknown with ESLint: 8.8.0
4 participants