Chore: Test fixes for config-array-factory.js #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mdjermanovic for your help. All the tests are now passing! 🎉 |
|
What's happening with macOS test, those look like real failures (not timeouts). |
|
Huh, wasn’t happening before. I have no idea what the problem is and I don’t have a Mac to test locally. |
|
Okay, so it looks like we are running into the infamous "temp directory on MacOS isn't returned correctly in Node.js" problem (nodejs/node#11422). I switched to using https://github.com/sindresorhus/temp-dir instead of the native utility. No idea why these tests weren't failing in the main repo before but all fixed now (with timeout!). |
btmills
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've converted all of the tests over, but three are still failing and I can't figure out why. Any help would be greatly appreciated.