Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to eleventy v3 #690

Merged
merged 1 commit into from
Feb 7, 2025
Merged

feat: upgrade to eleventy v3 #690

merged 1 commit into from
Feb 7, 2025

Conversation

Pixel998
Copy link
Contributor

@Pixel998 Pixel998 commented Feb 6, 2025

Prerequisites checklist

What is the purpose of this pull request?

The purpose of the pull request is to update the project to Eleventy version 3.

What changes did you make? (Give an overview)

Upgraded to Eleventy v3.

I ran the Upgrade Helper, and everything passed. I also tested the build, and it built without errors. I checked for regressions, but everything seems to work fine.

Related Issues

Fix #644

Is there anything you'd like reviewers to focus on?

Copy link

linux-foundation-easycla bot commented Feb 6, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0912ead
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/67a459d42dd9950008258b4f
😎 Deploy Preview https://deploy-preview-690--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 0912ead
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/67a459d4988f6200082cc361
😎 Deploy Preview https://deploy-preview-690--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 0912ead
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/67a459d44f1b2b000841cc81
😎 Deploy Preview https://deploy-preview-690--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 0912ead
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/67a459d485594d000801bbc4
😎 Deploy Preview https://deploy-preview-690--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 0912ead
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/67a459d4deb24700091d3030
😎 Deploy Preview https://deploy-preview-690--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 0912ead
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/67a459d49f06230008dd46ba
😎 Deploy Preview https://deploy-preview-690--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 0912ead
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/67a459d43f6f09000864d10b
😎 Deploy Preview https://deploy-preview-690--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 0912ead
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/67a459d42dd9950008258b54
😎 Deploy Preview https://deploy-preview-690--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this. Verified that the deploy preview is working and I haven't found any problems.

Would like another review before merging for sanity.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I verified that the output in _site is the same before and after.

@mdjermanovic mdjermanovic merged commit cc3d0fe into eslint:main Feb 7, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Suggestion: Investigate upgrading to Eleventy v3.0.0
3 participants