Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario descr rest api #130

Merged
merged 9 commits into from
Aug 3, 2020
Merged

Scenario descr rest api #130

merged 9 commits into from
Aug 3, 2020

Conversation

DenysGonchar
Copy link
Collaborator

@DenysGonchar DenysGonchar commented Aug 3, 2020

Implementation of /scenarios/{id}/info and update of /scenarios/{id} GET methods.
/scenarios/{id} is tested manually. I haven't extended tests for it since we are going to rework it in the next iteration.

@DenysGonchar DenysGonchar force-pushed the scenario-descr-rest-api branch from f656be1 to 8a75276 Compare August 3, 2020 12:54
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few cosmetic changes, otherwise seems great 🙂

src/rest_api/amoc_api_scenario_status.erl Outdated Show resolved Hide resolved
src/rest_api/amoc_api_scenario_status.erl Outdated Show resolved Hide resolved
src/rest_api/amoc_api_scenario_status.erl Outdated Show resolved Hide resolved
@DenysGonchar DenysGonchar force-pushed the scenario-descr-rest-api branch from c5126e6 to beb9d6d Compare August 3, 2020 16:10
Dockerfile Show resolved Hide resolved
@NelsonVides NelsonVides merged commit 8c8a237 into master Aug 3, 2020
@NelsonVides NelsonVides deleted the scenario-descr-rest-api branch August 3, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants