Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SET SESSION query_cache_type=1 in MySQL #4508

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

arcusfelis
Copy link
Contributor

This PR addresses MIM-2419

Proposed changes include:

  • Remove SET SESSION query_cache_type=1 in MySQL
  • It is not supported in MySQL 8
  • It returns {error,{1193,<<"HY000">>,<<"Unknown system variable 'query_cache_type'">>} but connection keeps working

It is not supported in MySQL 8
It returns {error,{1193,<<"HY000">>,<<"Unknown system variable 'query_cache_type'">>}
but connection keeps working
@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 18, 2025

elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 1357b71
Reports root/ big
OK: 683 / Failed: 0 / User-skipped: 72 / Auto-skipped: 0


small_tests_26 / small_tests / 1357b71
Reports root / small


small_tests_27 / small_tests / 1357b71
Reports root / small


small_tests_27_arm64 / small_tests / 1357b71
Reports root / small


ldap_mnesia_26 / ldap_mnesia / 1357b71
Reports root/ big
OK: 2373 / Failed: 0 / User-skipped: 1088 / Auto-skipped: 0


ldap_mnesia_27 / ldap_mnesia / 1357b71
Reports root/ big
OK: 2373 / Failed: 0 / User-skipped: 1088 / Auto-skipped: 0


dynamic_domains_mysql_redis_27 / mysql_redis / 1357b71
Reports root/ big
OK: 4907 / Failed: 0 / User-skipped: 181 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 1357b71
Reports root/ big
OK: 4942 / Failed: 0 / User-skipped: 146 / Auto-skipped: 0


internal_mnesia_27 / internal_mnesia / 1357b71
Reports root/ big
OK: 2545 / Failed: 1 / User-skipped: 915 / Auto-skipped: 0

pubsub_SUITE:tree+basic:request_all_items_test
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,445}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,435}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,425}]},
     {pubsub_SUITE,'-request_all_items_test/1-fun-0-',2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,553}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log


dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 1357b71
Reports root/ big
OK: 4937 / Failed: 0 / User-skipped: 151 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 1357b71
Reports root/ big
OK: 4942 / Failed: 0 / User-skipped: 146 / Auto-skipped: 0


pgsql_cets_27 / pgsql_cets / 1357b71
Reports root/ big
OK: 5031 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 1357b71
Reports root/ big
OK: 5334 / Failed: 0 / User-skipped: 155 / Auto-skipped: 0


pgsql_mnesia_27 / pgsql_mnesia / 1357b71
Reports root/ big
OK: 5334 / Failed: 0 / User-skipped: 155 / Auto-skipped: 0


mysql_redis_27 / mysql_redis / 1357b71
Reports root/ big
OK: 5313 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0


mssql_mnesia_27 / odbc_mssql_mnesia / 1357b71
Reports root/ big
OK: 5329 / Failed: 0 / User-skipped: 160 / Auto-skipped: 0


cockroachdb_cets_27 / cockroachdb_cets / 1357b71
Reports root/ big
OK: 5036 / Failed: 4 / User-skipped: 215 / Auto-skipped: 0

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3741@localhost/res1">>,
          escalus_tcp,<0.109435.0>,
          [{event_manager,<0.109433.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3741">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.109433.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3741">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3741">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3741">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"3de99f6af8078f1a">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_check...

Report log

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3743@localhost/res1">>,
          escalus_tcp,<0.109512.0>,
          [{event_manager,<0.109501.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3743">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.109501.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3743">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3743">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3743">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"bedaf9d522d14def">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_check...

Report log

pubsub_SUITE:tree+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3798@localhost/res1">>,
          escalus_tcp,<0.110794.0>,
          [{event_manager,<0.110784.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3798">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.110784.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3798">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3798">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3798">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"a32e8bdc80177d72">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_check...

Report log

s2s_SUITE:node1_tls_optional_node2_tls_required_trusted_with_cachain:simple_message
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alice_simple_message_4391@fed1/res1">>,escalus_tcp,
          <0.142262.0>,
          [{event_manager,<0.142082.0>},
           {server,<<"fed1">>},
           {username,<<"alice_simple_message_4391">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.142082.0>},
            {server,<<"fed1">>},
            {username,<<"alice_simple_message_4391">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_simple_message_4391">>},
           {server,<<"fed1">>},
           {host,<<"localhost">>},
           {port,5242},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alice_simple_message_4391">>},
           {server,<<"fed1">>},
           {host,<<"localhost">>},
           {port,5242},
           {password,<<"makota2">>},
           {stream_id,<<"5ae5c83c40f0cd6a">>}]},
        10000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {s2s_SUITE,'-simple_message/1-fun-0-',3,
       [{file,"/home/circleci/project/big_tests/tests/s2s_SUITE.erl"},
        {line,171}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,75}]},
     {test_server,ts_tc,3,...

Report log


internal_mnesia_27 / internal_mnesia / 1357b71
Reports root/ big
OK: 2546 / Failed: 0 / User-skipped: 915 / Auto-skipped: 0


cockroachdb_cets_27 / cockroachdb_cets / 1357b71
Reports root/ big
OK: 5037 / Failed: 3 / User-skipped: 215 / Auto-skipped: 0

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3141@localhost/res1">>,
          escalus_tcp,<0.109752.0>,
          [{event_manager,<0.109740.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3141">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.109740.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3141">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3141">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3141">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"7586e493e3dbb863">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_check...

Report log

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3145@localhost/res1">>,
          escalus_tcp,<0.109826.0>,
          [{event_manager,<0.109825.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3145">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.109825.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3145">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3145">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3145">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"da364b5698848cfc">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_check...

Report log

pubsub_SUITE:tree+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3198@localhost/res1">>,
          escalus_tcp,<0.111110.0>,
          [{event_manager,<0.111091.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3198">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.111091.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3198">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3198">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3198">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"aa12eedd13d1475a">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_check...

Report log

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (ddfb01b) to head (1357b71).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4508      +/-   ##
==========================================
+ Coverage   85.56%   85.60%   +0.04%     
==========================================
  Files         559      559              
  Lines       34066    34065       -1     
==========================================
+ Hits        29147    29161      +14     
+ Misses       4919     4904      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I can confirm that it was first deprecated, and then removed in MySQL 8.

@chrzaszcz chrzaszcz merged commit 4ef2739 into master Mar 18, 2025
4 checks passed
@chrzaszcz chrzaszcz deleted the remove-mysql-query_cache_type branch March 18, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants