Introduce wait_helper and remove duplicated coded helper #4418
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4418 +/- ##
==========================================
- Coverage 85.32% 85.32% -0.01%
==========================================
Files 550 550
Lines 33905 33905
==========================================
- Hits 28929 28928 -1
- Misses 4976 4977 +1 ☔ View full report in Codecov by Sentry. |
f8d9d1e to
c03b677
Compare
This comment was marked as outdated.
This comment was marked as outdated.
3d3daee to
a6e28b8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a6e28b8 to
85ed24b
Compare
|
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 85ed24b small_tests_26 / small_tests / 85ed24b small_tests_27 / small_tests / 85ed24b small_tests_27_arm64 / small_tests / 85ed24b ldap_mnesia_26 / ldap_mnesia / 85ed24b ldap_mnesia_27 / ldap_mnesia / 85ed24b dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 85ed24b internal_mnesia_27 / internal_mnesia / 85ed24b dynamic_domains_mysql_redis_27 / mysql_redis / 85ed24b dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 85ed24b dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 85ed24b muc_SUITE:register:user_submits_registration_form{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"fdb536832f8c90085d12ff120cba619a">>},
{<<"to">>,<<"groupchats.domain.example.com">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitchroom-3e5a6c7dd3">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"groupchats.domain.example.com">>},
{<<"to">>,
<<"alice_user_submits_registration_form_2949@domain.example.com/res1">>},
{<<"type">>,<<"error">>},
{<<"id">>,<<"fdb536832f8c90085d12ff120cba619a">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
...pgsql_cets_27 / pgsql_cets / 85ed24b mysql_redis_27 / mysql_redis / 85ed24b pgsql_mnesia_27 / pgsql_mnesia / 85ed24b pgsql_mnesia_26 / pgsql_mnesia / 85ed24b cockroachdb_cets_27 / cockroachdb_cets / 85ed24b pubsub_SUITE:dag+node_config:disable_payload_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"alice_disable_payload_test_3230@localhost/res1">>,
escalus_tcp,<0.77594.0>,
[{event_manager,<0.77558.0>},
{server,<<"localhost">>},
{username,<<"alicE_disable_payload_test_3230">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.77558.0>},
{server,<<"localhost">>},
{username,<<"alicE_disable_payload_test_3230">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_disable_payload_test_3230">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_disable_payload_test_3230">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"09f4a32b50c43bac">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,433}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{escalus_story,story,4,
[{file,
...pubsub_SUITE:dag+manage_subscriptions:modify_node_subscriptions_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_modify_node_subscriptions_test_3253@localhost/res1">>,
escalus_tcp,<0.77908.0>,
[{event_manager,<0.77897.0>},
{server,<<"localhost">>},
{username,<<"alicE_modify_node_subscriptions_test_3253">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.77897.0>},
{server,<<"localhost">>},
{username,
<<"alicE_modify_node_subscriptions_test_3253">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_modify_node_subscriptions_test_3253">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_modify_node_subscriptions_test_3253">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"eed6ca6df9ba260e">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,433}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"}...mssql_mnesia_27 / odbc_mssql_mnesia / 85ed24b dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 85ed24b |
This helper was coded twice in two different helpers, and it was long ago extracted into a dependency we could be using here instead.