Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument/mod muc #4268

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Instrument/mod muc #4268

merged 4 commits into from
Apr 24, 2024

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Apr 17, 2024

This PR converts mod_muc metrics from mongoose_metrics to mongoose_instrument.

  • One probe is used for counting online and hibernated rooms to reduce duplication of work.
  • Metrics are per-host-type now (they were global before).
  • Instrumentation helpers for big tests are updated to allow testing probes.

More details in commit messages.

Note: In the current implementation, probes are started when instrumentation events are set up. As a result, the module is not started yet, while the probe is already enabled. There is a similar possibility of a race condition when a module is being stopped. This is why a try ... catch is required in mod_muc:count_rooms/1. A solution might be to start probes after starting the module, but this would make the code more complex. We could do it in a separate story if needed.

@chrzaszcz chrzaszcz changed the base branch from master to feature/instrument April 17, 2024 15:36
@chrzaszcz chrzaszcz force-pushed the instrument/mod_muc branch from 10f4b80 to 65159a7 Compare April 17, 2024 15:38
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.33%. Comparing base (a79d1e7) to head (de64343).

Files Patch % Lines
src/muc/mod_muc.erl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/instrument    #4268   +/-   ##
===================================================
  Coverage               84.32%   84.33%           
===================================================
  Files                     557      555    -2     
  Lines                   33740    33720   -20     
===================================================
- Hits                    28451    28437   -14     
+ Misses                   5289     5283    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrzaszcz chrzaszcz force-pushed the instrument/mod_muc branch 2 times, most recently from 9a1b237 to 23330dc Compare April 18, 2024 10:52
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@chrzaszcz chrzaszcz force-pushed the instrument/mod_muc branch from 23330dc to 8ec1de4 Compare April 18, 2024 11:07
@mongoose-im

This comment was marked as outdated.

@chrzaszcz chrzaszcz force-pushed the instrument/mod_muc branch from 8ec1de4 to 9178ff3 Compare April 18, 2024 11:57
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@chrzaszcz chrzaszcz force-pushed the instrument/mod_muc branch from 8ccbee1 to 79264ca Compare April 19, 2024 10:38
@mongoose-im

This comment was marked as outdated.

@chrzaszcz chrzaszcz force-pushed the instrument/mod_muc branch from 79264ca to 392d20f Compare April 22, 2024 14:04
@mongoose-im

This comment was marked as outdated.

@chrzaszcz chrzaszcz force-pushed the instrument/mod_muc branch from 392d20f to b4ee490 Compare April 22, 2024 14:50
@chrzaszcz chrzaszcz changed the base branch from feature/instrument to instrument/probe April 22, 2024 14:52
@mongoose-im
Copy link
Collaborator

mongoose-im commented Apr 22, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / b4ee490
Reports root/ big
OK: 447 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0


small_tests_25 / small_tests / b4ee490
Reports root / small


small_tests_26 / small_tests / b4ee490
Reports root / small


small_tests_26_arm64 / small_tests / b4ee490
Reports root / small


ldap_mnesia_25 / ldap_mnesia / b4ee490
Reports root/ big
OK: 2126 / Failed: 0 / User-skipped: 893 / Auto-skipped: 163

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"localhost">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"localhost">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1379}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


ldap_mnesia_26 / ldap_mnesia / b4ee490
Reports root/ big
OK: 2126 / Failed: 0 / User-skipped: 893 / Auto-skipped: 163

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"localhost">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"localhost">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1390}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


dynamic_domains_mysql_redis_26 / mysql_redis / b4ee490
Reports root/ big
OK: 4388 / Failed: 0 / User-skipped: 138 / Auto-skipped: 155

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"test type">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"test type">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1390}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b4ee490
Reports root/ big
OK: 4421 / Failed: 0 / User-skipped: 105 / Auto-skipped: 155

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"test type">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"test type">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1379}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / b4ee490
Reports root/ big
OK: 4418 / Failed: 0 / User-skipped: 108 / Auto-skipped: 155

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"test type">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"test type">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1390}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / b4ee490
Reports root/ big
OK: 4421 / Failed: 0 / User-skipped: 105 / Auto-skipped: 155

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"test type">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"test type">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1390}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


internal_mnesia_26 / internal_mnesia / b4ee490
Reports root/ big
OK: 2266 / Failed: 0 / User-skipped: 753 / Auto-skipped: 163

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"localhost">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"localhost">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1390}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


pgsql_cets_26 / pgsql_cets / b4ee490
Reports root/ big
OK: 4318 / Failed: 0 / User-skipped: 174 / Auto-skipped: 163

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"localhost">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"localhost">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1390}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


pgsql_mnesia_25 / pgsql_mnesia / b4ee490
Reports root/ big
OK: 4802 / Failed: 0 / User-skipped: 112 / Auto-skipped: 163

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"localhost">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"localhost">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1379}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mysql_redis_26 / mysql_redis / b4ee490
Reports root/ big
OK: 4781 / Failed: 0 / User-skipped: 133 / Auto-skipped: 163

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"localhost">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"localhost">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1390}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


pgsql_mnesia_26 / pgsql_mnesia / b4ee490
Reports root/ big
OK: 4802 / Failed: 0 / User-skipped: 112 / Auto-skipped: 163

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"localhost">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"localhost">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1390}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


mssql_mnesia_26 / odbc_mssql_mnesia / b4ee490
Reports root/ big
OK: 4799 / Failed: 0 / User-skipped: 115 / Auto-skipped: 163

muc_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',{undef,[{mod_muc,instrumentation,[<<"localhost">>],[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mod_muc,instrumentation,
       [<<"localhost">>]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,140}]},
    {instrument_helper,declared_events,1,
      [{file,
         "/home/circleci/project/big_tests/tests/instrument_helper.erl"},
       {line,26}]},
    {muc_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
       {line,333}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1390}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log

@chrzaszcz chrzaszcz force-pushed the instrument/probe branch 3 times, most recently from 7b817ff to a1c639f Compare April 23, 2024 06:43
Base automatically changed from instrument/probe to feature/instrument April 23, 2024 23:17
@chrzaszcz chrzaszcz force-pushed the instrument/mod_muc branch from b4ee490 to 84b71e8 Compare April 24, 2024 07:52
@mongoose-im
Copy link
Collaborator

mongoose-im commented Apr 24, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 84b71e8
Reports root/ big
OK: 447 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0


small_tests_25 / small_tests / 84b71e8
Reports root / small


small_tests_26 / small_tests / 84b71e8
Reports root / small


small_tests_26_arm64 / small_tests / 84b71e8
Reports root / small


ldap_mnesia_26 / ldap_mnesia / 84b71e8
Reports root/ big
OK: 2285 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 84b71e8
Reports root/ big
OK: 4576 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 84b71e8
Reports root/ big
OK: 2285 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 84b71e8
Reports root/ big
OK: 4543 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 84b71e8
Reports root/ big
OK: 4573 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 84b71e8
Reports root/ big
OK: 4576 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 84b71e8
Reports root/ big
OK: 2425 / Failed: 0 / User-skipped: 757 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 84b71e8
Reports root/ big
OK: 4965 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 84b71e8
Reports root/ big
OK: 4481 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 84b71e8
Reports root/ big
OK: 4944 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 84b71e8
Reports root/ big
OK: 4965 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 84b71e8
Reports root/ big
OK: 4962 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0

Make it possible to take instrumentation events from the table.
This makes it easier to test probes, because previous values can be erased.
@chrzaszcz chrzaszcz force-pushed the instrument/mod_muc branch from 84b71e8 to de64343 Compare April 24, 2024 08:14
@mongoose-im
Copy link
Collaborator

mongoose-im commented Apr 24, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / de64343
Reports root/ big
OK: 447 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0


small_tests_25 / small_tests / de64343
Reports root / small


small_tests_26 / small_tests / de64343
Reports root / small


small_tests_26_arm64 / small_tests / de64343
Reports root / small


ldap_mnesia_25 / ldap_mnesia / de64343
Reports root/ big
OK: 2285 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / de64343
Reports root/ big
OK: 4576 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / de64343
Reports root/ big
OK: 4543 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / de64343
Reports root/ big
OK: 2284 / Failed: 1 / User-skipped: 897 / Auto-skipped: 0

sm_SUITE:ping_timeout
{error,{noproc,{gen_server,call,[<0.60939.0>,get_sm_h]}}}

Report log


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / de64343
Reports root/ big
OK: 4576 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / de64343
Reports root/ big
OK: 4481 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / de64343
Reports root/ big
OK: 4572 / Failed: 1 / User-skipped: 108 / Auto-skipped: 0

sm_SUITE:ping_timeout
{error,{noproc,{gen_server,call,[<0.86443.0>,get_sm_h]}}}

Report log


internal_mnesia_26 / internal_mnesia / de64343
Reports root/ big
OK: 2425 / Failed: 0 / User-skipped: 757 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / de64343
Reports root/ big
OK: 4944 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / de64343
Reports root/ big
OK: 4965 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / de64343
Reports root/ big
OK: 4962 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / de64343
Reports root/ big
OK: 4964 / Failed: 1 / User-skipped: 112 / Auto-skipped: 0

graphql_SUITE:tls_enabled:tls_connect_admin_unknown_certificate
{error,{{assertMatch,[{module,graphql_SUITE},
            {line,253},
            {expression,"Result"},
            {pattern,"{ error , { tls_alert , { unknown_ca , _ } } }"},
            {value,{error,connection_closed}}]},
    [{graphql_SUITE,tls_connect_admin_unknown_certificate,1,
            [{file,"/home/circleci/project/big_tests/tests/graphql_SUITE.erl"},
             {line,253}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log


ldap_mnesia_26 / ldap_mnesia / de64343
Reports root/ big
OK: 2285 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / de64343
Reports root/ big
OK: 4573 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / de64343
Reports root/ big
OK: 4965 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

@chrzaszcz chrzaszcz marked this pull request as ready for review April 24, 2024 09:41
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@arcusfelis arcusfelis merged commit ea2ae4d into feature/instrument Apr 24, 2024
3 of 4 checks passed
@arcusfelis arcusfelis deleted the instrument/mod_muc branch April 24, 2024 15:22
@jacekwegr jacekwegr added this to the 6.3.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants