-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xep attributes for 178 and add for 220 #4057
Conversation
small_tests_24 / small_tests / 99435ba elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 99435ba small_tests_25_arm64 / small_tests / 99435ba small_tests_25 / small_tests / 99435ba ldap_mnesia_24 / ldap_mnesia / 99435ba dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 99435ba ldap_mnesia_25 / ldap_mnesia / 99435ba dynamic_domains_mysql_redis_25 / mysql_redis / 99435ba dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 99435ba mam_SUITE:rdbms_async_pool_muc_all:muc06:muc_message_with_stanzaid{failed,
{mam_SUITE,end_per_testcase,
{'EXIT',
{{room_archive_size,0,[{times,200,1}],ok},
[{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,357}]},
{mam_helper,wait_for_room_archive_size,3,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,789}]},
{mam_helper,clean_room_archive,1,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,733}]},
{mam_helper,destroy_room,1,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,726}]},
{mam_SUITE,end_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
{line,954}]},
{test_server,do_end_per_testcase,4,
[{file,"test_server.erl"},{line,1626}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1334}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}}} dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 99435ba pgsql_mnesia_24 / pgsql_mnesia / 99435ba internal_mnesia_25 / internal_mnesia / 99435ba mod_global_distrib_SUITE:hosts_refresher:test_host_refreshing{error,
{{trees_for_connections_present,true,[{times,50,false}],ok},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,357}]},
{mod_global_distrib_SUITE,test_host_refreshing,1,
[{file,
"/home/circleci/project/big_tests/tests/mod_global_distrib_SUITE.erl"},
{line,384}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} pgsql_mnesia_25 / pgsql_mnesia / 99435ba mysql_redis_25 / mysql_redis / 99435ba mssql_mnesia_25 / odbc_mssql_mnesia / 99435ba mam_SUITE:rdbms_async_pool_muc_all:muc06:muc_message_with_stanzaid{failed,
{mam_SUITE,end_per_testcase,
{'EXIT',
{{room_archive_size,0,[{times,200,1}],ok},
[{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,357}]},
{mam_helper,wait_for_room_archive_size,3,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,789}]},
{mam_helper,clean_room_archive,1,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,733}]},
{mam_helper,destroy_room,1,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,726}]},
{mam_SUITE,end_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
{line,954}]},
{test_server,do_end_per_testcase,4,
[{file,"test_server.erl"},{line,1626}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1334}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}}} internal_mnesia_25 / internal_mnesia / 99435ba |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4057 +/- ##
==========================================
- Coverage 83.87% 83.87% -0.01%
==========================================
Files 526 526
Lines 33133 33133
==========================================
- Hits 27790 27789 -1
- Misses 5343 5344 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
This PR updates XEP-0178 version. It's still partial since we support only client-server SASL EXTERNAL.
It also adds an attribute for XEP-0220 which was already fully supported and implemented in
ejabberd_s2s_in
andejabberd_s2s_out
. I decided to put it only in one module to avoid mess. Infeature/cets
branch there's ongoing refactor of diaback, so this attribute should be only in newly introduced module after merge.