-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored hook handlers in ejabberd_router module #3760
Conversation
small_tests_24 / small_tests / bbb4d09 small_tests_25 / small_tests / bbb4d09 ldap_mnesia_24 / ldap_mnesia / bbb4d09 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bbb4d09 dynamic_domains_mysql_redis_25 / mysql_redis / bbb4d09 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / bbb4d09 ldap_mnesia_25 / ldap_mnesia / bbb4d09 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / bbb4d09 internal_mnesia_25 / internal_mnesia / bbb4d09 pgsql_mnesia_24 / pgsql_mnesia / bbb4d09 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2457@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2457@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"fwKRjk7HcblmuSLF/K7Q3A==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / bbb4d09 pgsql_mnesia_25 / pgsql_mnesia / bbb4d09 mysql_redis_25 / mysql_redis / bbb4d09 riak_mnesia_24 / riak_mnesia / bbb4d09 mssql_mnesia_25 / odbc_mssql_mnesia / bbb4d09 small_tests_24 / small_tests / bbb4d09 small_tests_25 / small_tests / bbb4d09 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bbb4d09 ldap_mnesia_24 / ldap_mnesia / bbb4d09 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / bbb4d09 dynamic_domains_mysql_redis_25 / mysql_redis / bbb4d09 ldap_mnesia_25 / ldap_mnesia / bbb4d09 internal_mnesia_25 / internal_mnesia / bbb4d09 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / bbb4d09 pgsql_mnesia_24 / pgsql_mnesia / bbb4d09 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / bbb4d09 pgsql_mnesia_25 / pgsql_mnesia / bbb4d09 mysql_redis_25 / mysql_redis / bbb4d09 mssql_mnesia_25 / odbc_mssql_mnesia / bbb4d09 riak_mnesia_24 / riak_mnesia / bbb4d09 |
Codecov ReportBase: 82.71% // Head: 82.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3760 +/- ##
=======================================
Coverage 82.71% 82.72%
=======================================
Files 529 529
Lines 33976 33977 +1
=======================================
+ Hits 28103 28107 +4
+ Misses 5873 5870 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bbb4d09
to
024fe41
Compare
small_tests_24 / small_tests / 024fe41 small_tests_25 / small_tests / 024fe41 ldap_mnesia_24 / ldap_mnesia / 024fe41 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 024fe41 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 024fe41 dynamic_domains_mysql_redis_25 / mysql_redis / 024fe41 ldap_mnesia_25 / ldap_mnesia / 024fe41 bosh_SUITE:essential_https:accept_higher_hold_value{error,
{{assertEqual,
[{module,bosh_SUITE},
{line,251},
{expression,"get_bosh_sessions ( )"},
{expected,[]},
{value,
[{bosh_session,<<"87be7030b26aed54d76f82395037ebcee3185c46">>,
<9155.5349.0>}]}]},
[{bosh_SUITE,accept_higher_hold_value,1,
[{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
{line,251}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} pgsql_mnesia_24 / pgsql_mnesia / 024fe41 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 024fe41 internal_mnesia_25 / internal_mnesia / 024fe41 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 024fe41 mysql_redis_25 / mysql_redis / 024fe41 pgsql_mnesia_25 / pgsql_mnesia / 024fe41 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2347@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2347@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"JvoetH3zhzbY/vwYv8L6YA==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mssql_mnesia_25 / odbc_mssql_mnesia / 024fe41 riak_mnesia_24 / riak_mnesia / 024fe41 ldap_mnesia_25 / ldap_mnesia / 024fe41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward, lgtm 👌🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
This PR changes all hook handlers in
ejabberd_router
module togen_hook
format.