-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use podman instead of docker #3522
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #3522 +/- ##
==========================================
+ Coverage 81.08% 81.09% +0.01%
==========================================
Files 419 419
Lines 32298 32298
==========================================
+ Hits 26188 26193 +5
+ Misses 6110 6105 -5
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / dccae65 small_tests_23 / small_tests / dccae65 dynamic_domains_mysql_redis_24 / mysql_redis / dccae65 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / dccae65 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / dccae65 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / dccae65 ldap_mnesia_23 / ldap_mnesia / dccae65 ldap_mnesia_24 / ldap_mnesia / dccae65 internal_mnesia_24 / internal_mnesia / dccae65 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / dccae65 pgsql_mnesia_24 / pgsql_mnesia / dccae65 pgsql_mnesia_23 / pgsql_mnesia / dccae65 mssql_mnesia_24 / odbc_mssql_mnesia / dccae65 mysql_redis_24 / mysql_redis / dccae65 riak_mnesia_24 / riak_mnesia / dccae65 |
small_tests_24 / small_tests / 3aa83cc small_tests_23 / small_tests / 3aa83cc dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 3aa83cc dynamic_domains_mysql_redis_24 / mysql_redis / 3aa83cc dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 3aa83cc ldap_mnesia_23 / ldap_mnesia / 3aa83cc ldap_mnesia_24 / ldap_mnesia / 3aa83cc internal_mnesia_24 / internal_mnesia / 3aa83cc pgsql_mnesia_24 / pgsql_mnesia / 3aa83cc service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>],
[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>,<<"example4.com">>]}}} elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 3aa83cc pgsql_mnesia_23 / pgsql_mnesia / 3aa83cc mysql_redis_24 / mysql_redis / 3aa83cc mssql_mnesia_24 / odbc_mssql_mnesia / 3aa83cc riak_mnesia_24 / riak_mnesia / 3aa83cc pgsql_mnesia_24 / pgsql_mnesia / 3aa83cc |
small_tests_24 / small_tests / 917223f small_tests_23 / small_tests / 917223f dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 917223f dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 917223f dynamic_domains_mysql_redis_24 / mysql_redis / 917223f dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 917223f ldap_mnesia_23 / ldap_mnesia / 917223f ldap_mnesia_24 / ldap_mnesia / 917223f internal_mnesia_24 / internal_mnesia / 917223f pgsql_mnesia_23 / pgsql_mnesia / 917223f pgsql_mnesia_24 / pgsql_mnesia / 917223f mysql_redis_24 / mysql_redis / 917223f elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 917223f mssql_mnesia_24 / odbc_mssql_mnesia / 917223f riak_mnesia_24 / riak_mnesia / 917223f |
small_tests_24 / small_tests / 38762c3 small_tests_23 / small_tests / 38762c3 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 38762c3 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 38762c3 dynamic_domains_mysql_redis_24 / mysql_redis / 38762c3 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 38762c3 ldap_mnesia_23 / ldap_mnesia / 38762c3 ldap_mnesia_24 / ldap_mnesia / 38762c3 internal_mnesia_24 / internal_mnesia / 38762c3 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 38762c3 pgsql_mnesia_24 / pgsql_mnesia / 38762c3 pgsql_mnesia_23 / pgsql_mnesia / 38762c3 mysql_redis_24 / mysql_redis / 38762c3 mssql_mnesia_24 / odbc_mssql_mnesia / 38762c3 vcard_SUITE:ro_full:retrieve_own_card{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}} riak_mnesia_24 / riak_mnesia / 38762c3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR addresses "Desktop docker license change" MIM-1598.
Proposed changes include:
And you can put
alias docker=podman
into your bash init script.https://podman.io/whatis.html
What's else? It takes one hour to compile qemu (a dependency of podman) :D
One more thing, by default, podman machine takes 2GB of memory.
This means that after starting all other databases (i.e. primarily cassandra and elastic), starting mssql would fail (i.e. "podman ps" would not respond for some time, but after a minute, mssql container just stops and everything is fine). The solution is simple - just stop other containers in this case - it would release memory and make MSSQL happy (after that you can start these containers again, apparently).