Multi tenancy init #3061

DenysGonchar · 2021-03-23T03:02:53Z

this PR introduces the next changes:

solves race condition at check_for_updates/2 function
eliminates the need to restart mongoose_domain_core if service_domain_db crashes on initial loading
eliminates the need to halt the node if service_domain_db goes out of sync
ensures proper init of the mongoose_domain_core
introduces 2 dummy test suites for the future development.

Also now it's possible to implement "hooks" for domains adding/removing if there's such a need

for testing run: test-runner.sh --skip-cover --skip-small-tests --preset pgsql_mnesia --db pgsql -- service_domain_db ./rebar3 ct --suite mongoose_domain_core_SUITE

test-runner.sh --skip-cover --skip-small-tests --preset pgsql_mnesia --db pgsql --dev-nodes mim1 mim2 -- dynamic_domains_pm

codecov · 2021-03-23T03:20:28Z

Codecov Report

Merging #3061 (194e07a) into multi-tenancy-phase-1 (f991ee2) will increase coverage by 0.59%.
The diff coverage is 89.80%.

@@                    Coverage Diff                    @@
##           multi-tenancy-phase-1    #3061      +/-   ##
=========================================================
+ Coverage                  78.09%   78.69%   +0.59%     
=========================================================
  Files                        374      386      +12     
  Lines                      31219    31610     +391     
=========================================================
+ Hits                       24382    24877     +495     
+ Misses                      6837     6733     -104

Impacted Files	Coverage Δ
src/admin_extra/service_admin_extra.erl	`100.00% <ø> (ø)`
src/auth/ejabberd_auth_anonymous.erl	`48.75% <0.00%> (-1.25%)`	⬇️
src/ejabberd_gen_sm.erl	`90.90% <ø> (ø)`
src/ejabberd_local.erl	`62.68% <0.00%> (-1.50%)`	⬇️
src/muc_light/mod_muc_light_db_mnesia.erl	`89.47% <ø> (+4.47%)`	⬆️
src/offline/mod_offline_mnesia.erl	`51.47% <0.00%> (ø)`
src/pubsub/pubsub_form_utils.erl	`56.60% <0.00%> (+1.04%)`	⬆️
src/rdbms/rdbms_queries_mssql.erl	`100.00% <ø> (ø)`
src/rdbms/mongoose_rdbms_odbc.erl	`75.78% <45.45%> (-1.86%)`	⬇️
src/mam/mod_mam_rdbms_arch.erl	`48.45% <47.14%> (+9.18%)`	⬆️
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc788d...194e07a. Read the comment docs.

arcusfelis

added some comments

arcusfelis · 2021-03-23T07:34:03Z

src/domain/service_domain_db.erl

-    State = #{last_event_id => LastEventId,
-              check_for_updates_interval => 30000},
-    {ok, handle_check_for_updates(State)}.
+    gen_server:cast(self(),initial_loading),


It will unblock execution, introducing new set of errors (i.e. domain is not on the node yet).
I highly recommend to not continue execution, unless every domain is on MongooseIM side.

We even don't allow that when syncing mnesia.

TLDR: you will have issues here.

I was thinking about unblocking initialisation of other modules/services.
Mostly like we will have to introduce some REST API check to ensure that node is ready for adding to load balancer.

Anyway it's relatively easy to roll back that change if required later.

src/domain/service_domain_db.erl

src/domain/mongoose_domain_sql.erl

src/domain/mongoose_domain_loader.erl

src/domain/mongoose_domain_core.erl

big_tests/tests/service_domain_db_SUITE.erl

src/domain/mongoose_domain_sql.erl

mostly functions renaming and whitespaces.

chrzaszcz

Good changes! Just a few comments from me.

big_tests/tests/dynamic_domains_pm_SUITE.erl

rel/files/mongooseim.toml

big_tests/tests/service_domain_db_SUITE.erl

src/domain/mongoose_domain_api.erl

src/domain/mongoose_domain_sql.erl

src/domain/mongoose_domain_loader.erl

…toml

…i-tenancy-init

test/mongoose_domain_core_SUITE.erl

chrzaszcz

I also had a quick look, it seems good!

DenysGonchar added 8 commits March 17, 2021 22:50

fixing typos

ccb6be9

fixing race condition at mongoose_domain_loader:check_for_updates/2

e235578

implementing proper init for mongoose_domain_core

5ea6e78

adding basic unit tests for mongoose_domain_core

1be30c4

for testing run: test-runner.sh --skip-cover --skip-small-tests --preset pgsql_mnesia --db pgsql -- service_domain_db ./rebar3 ct --suite mongoose_domain_core_SUITE

basic suite for testing 1-2-1 messages fordynamic domains

e93a77b

test-runner.sh --skip-cover --skip-small-tests --preset pgsql_mnesia --db pgsql --dev-nodes mim1 mim2 -- dynamic_domains_pm

adding tracking of the source pid for the added dynamic domains

960650f

avoiding mongoose_domain_core crashes in service_domain_db:init/1

6b5ae8d

avoid node crashes if service_domain_db goes out of sync

360ae08

DenysGonchar requested a review from chrzaszcz March 23, 2021 03:03

DenysGonchar requested a review from arcusfelis March 23, 2021 08:20

arcusfelis requested changes Mar 23, 2021

View reviewed changes

DenysGonchar added 2 commits March 24, 2021 14:59

applying changes after review

cd9ca2a

mostly functions renaming and whitespaces.

moving last event id to persistent_term storage

4e5aad0

chrzaszcz reviewed Mar 25, 2021

View reviewed changes

DenysGonchar added 2 commits March 26, 2021 11:15

some more changes after code review

fe627f8

fixing and renaming db_initial_load_crashes_node testcase

9743f99

DenysGonchar force-pushed the multi-tenancy-init branch from 6503c50 to 9743f99 Compare March 26, 2021 10:34

DenysGonchar added 5 commits March 27, 2021 05:15

adding db_restarts_properly test case for service_domain_db

8110cee

removing 'test type' host type configuration from default mongooseim.…

95a40e9

…toml

setting source for domain names in mongoose_domain_core explicitely

7170272

making endless recursion impossible in mongoose_domain_sql

b8e04cb

extending mongoose_domain_core_SUITE

86e8fd8

DenysGonchar force-pushed the multi-tenancy-init branch from 4d5cd7a to 86e8fd8 Compare March 27, 2021 04:16

Merge remote-tracking branch 'origin/multi-tenancy-phase-1' into mult…

194e07a

…i-tenancy-init

arcusfelis merged commit b5ad312 into multi-tenancy-phase-1 Mar 27, 2021

arcusfelis deleted the multi-tenancy-init branch March 27, 2021 20:40

chrzaszcz reviewed Mar 29, 2021

View reviewed changes

test/mongoose_domain_core_SUITE.erl Show resolved Hide resolved

chrzaszcz reviewed Mar 29, 2021

View reviewed changes

DenysGonchar mentioned this pull request Apr 22, 2021

Multi tenancy phase 1 #3095

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi tenancy init #3061

Multi tenancy init #3061

DenysGonchar commented Mar 23, 2021 •

edited

Loading

codecov bot commented Mar 23, 2021 •

edited

Loading

arcusfelis left a comment

arcusfelis Mar 23, 2021

DenysGonchar Mar 23, 2021

chrzaszcz left a comment

chrzaszcz left a comment

Multi tenancy init #3061

Multi tenancy init #3061

Conversation

DenysGonchar commented Mar 23, 2021 • edited Loading

codecov bot commented Mar 23, 2021 • edited Loading

Codecov Report

arcusfelis left a comment

Choose a reason for hiding this comment

arcusfelis Mar 23, 2021

Choose a reason for hiding this comment

DenysGonchar Mar 23, 2021

Choose a reason for hiding this comment

chrzaszcz left a comment

Choose a reason for hiding this comment

chrzaszcz left a comment

Choose a reason for hiding this comment

DenysGonchar commented Mar 23, 2021 •

edited

Loading

codecov bot commented Mar 23, 2021 •

edited

Loading