Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebar3 and plugins update #2760

Merged
merged 4 commits into from
May 27, 2020
Merged

Rebar3 and plugins update #2760

merged 4 commits into from
May 27, 2020

Conversation

michalwski
Copy link
Contributor

When updating our deps I noticed that all our rebar3 plugins are outdated and are not able to correctly compile some C code, like a newer jiffy (newer than 1.0.1).
I also observed issues with the previous rebar3 when it was not able to download some versions of hex packages even if they were visible on the web page.

Proposed changes include:

  • update rebar3 to 3.13.2
  • update rebar3 plugins
  • disable the rebar_faster_deps

@mongoose-im
Copy link
Collaborator

mongoose-im commented May 27, 2020 •
edited
Loading

8307.1 / Erlang 22.0 / small_tests / 7acd816
Reports root / small

8307.2 / Erlang 22.0 / internal_mnesia / 7acd816
Reports root/ big
OK: 1460 / Failed: 0 / User-skipped: 157 / Auto-skipped: 0

8307.3 / Erlang 22.0 / odbc_mssql_mnesia / 7acd816
Reports root/ big
OK: 2733 / Failed: 0 / User-skipped: 212 / Auto-skipped: 0

8307.4 / Erlang 22.0 / mysql_redis / 7acd816
Reports root/ big
OK: 2728 / Failed: 0 / User-skipped: 217 / Auto-skipped: 0

8307.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 7acd816
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

8307.6 / Erlang 22.0 / ldap_mnesia / 7acd816
Reports root/ big
OK: 1368 / Failed: 0 / User-skipped: 249 / Auto-skipped: 0

8307.5 / Erlang 22.0 / riak_mnesia / 7acd816
Reports root/ big
OK: 1586 / Failed: 0 / User-skipped: 177 / Auto-skipped: 0

8307.9 / Erlang 21.3 / pgsql_mnesia / 7acd816
Reports root/ big / small
OK: 2746 / Failed: 0 / User-skipped: 199 / Auto-skipped: 0

@michalwski michalwski requested a review from chrzaszcz May 27, 2020 08:51
@codecov
Copy link

codecov bot commented May 27, 2020 •
edited
Loading

Codecov Report

Merging #2760 into master will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
- Coverage   79.34%   78.95%   -0.39%     
==========================================
  Files         372      372              
  Lines       30556    30556              
==========================================
- Hits        24245    24126     -119     
- Misses       6311     6430     +119
Impacted Files Coverage Δ
src/inbox/mod_inbox_rdbms_mssql.erl 0.00% <0.00%> (-100.00%) ⬇️
src/rdbms/rdbms_queries_mssql.erl 0.00% <0.00%> (-85.72%) ⬇️
src/rdbms/mongoose_rdbms_odbc.erl 10.84% <0.00%> (-69.88%) ⬇️
src/ejabberd_rdbms.erl 88.88% <0.00%> (-11.12%) ⬇️
src/metrics/mongoose_metrics.erl 86.09% <0.00%> (-7.95%) ⬇️
src/mongoose_lib.erl 78.57% <0.00%> (-7.15%) ⬇️
src/rdbms/rdbms_queries.erl 77.33% <0.00%> (-6.90%) ⬇️
src/event_pusher/mod_event_pusher.erl 86.11% <0.00%> (-5.56%) ⬇️
src/pubsub/mod_pubsub_db_rdbms_sql.erl 89.21% <0.00%> (-4.91%) ⬇️
src/wpool/mongoose_wpool_rdbms.erl 79.16% <0.00%> (-4.17%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e5bbe...d74bd65. Read the comment docs.

chrzaszcz
chrzaszcz reviewed May 27, 2020
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the versions, they look good, I just have a few questions.

rebar.config Outdated Show resolved Hide resolved
rebar.config Show resolved Hide resolved
michalwski added 2 commits May 27, 2020 13:05
@michalwski
Disable rebar_faster_deps because it crashes rebar3
ae03d5d 
This pluging is currently outdate and doesn't work with newest rebar3.
We need newer rebar3 as with the older one (3.6) I observed issues
downloading some hex packages.

According to the following warning:
```
===> [rebar_faster_deps] Example: PREFER_GIT_CLONE=true ./rebar3 get-deps
===> Using custom resource rebar_gitcache_resource that implements a deprecated api. It should be upgraded to rebar_resource_v2.
```

This plugin uses deprecated api, which most probably crashes newest
rebar3 when upgrading some dependencies.
@michalwski
use esl/rebar3_codecov plugin
d74bd65
chrzaszcz
chrzaszcz approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now!

@chrzaszcz chrzaszcz merged commit 10b8817 into master May 27, 2020
@chrzaszcz chrzaszcz deleted the plugins-update branch May 27, 2020 12:37
@NelsonVides NelsonVides added this to the 3.7.1 milestone Jul 13, 2020
@vkatsuba vkatsuba mentioned this pull request Jul 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@michalwski @mongoose-im @chrzaszcz @NelsonVides