Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add tests #63

Merged
merged 2 commits into from
Jul 9, 2024
Merged

perf: add tests #63

merged 2 commits into from
Jul 9, 2024

Conversation

lffg
Copy link
Contributor

@lffg lffg commented Jun 22, 2024

Multi node tests aren't working yet.

Since we're running the performance tests in a docker context (i.e., the controller and each worker live in docker containers), the workers' proxy can't reach the underlying application container (created by Tucano) since they're in effectively different (docker) networks.

parts.authority = Authority::from_str(&format!("127.0.0.1:{port}")).ok();

This works in a "normal" Tucano setup because in this case the worker is in fact the "host" (in the docker networking point of view). When Tucano creates the underlying application container and publishes (to the host) the chosen port, the worker can access it through 127.0.0.1:{port}.

However, when a worker is running through docker (as we're doing in this performance test setup), it isn't the host anymore, not being able to access the underlying application container through 127.0.0.1 anymore.

@lemosep

This comment was marked as resolved.

@lffg
Copy link
Contributor Author

lffg commented Jul 9, 2024

Multi node tests aren't working yet.

Since we're running the performance tests in a docker context (i.e., the controller and each worker live in docker containers), the workers' proxy can't reach the underlying application container (created by Tucano) since they're in effectively different (docker) networks.

parts.authority = Authority::from_str(&format!("127.0.0.1:{port}")).ok();

This works in a "normal" Tucano setup because in this case the worker is in fact the "host" (in the docker networking point of view). When Tucano creates the underlying application container and publishes (to the host) the chosen port, the worker can access it through 127.0.0.1:{port}.

However, when a worker is running through docker (as we're doing in this performance test setup), it isn't the host anymore, not being able to access the underlying application container through 127.0.0.1 anymore.

Fixed per 077918c

@lffg lffg merged commit 4cff9f3 into main Jul 9, 2024
3 checks passed
@lffg lffg deleted the perf-tests branch July 9, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants