Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi node tests aren't working yet.
Since we're running the performance tests in a docker context (i.e., the controller and each worker live in docker containers), the workers' proxy can't reach the underlying application container (created by Tucano) since they're in effectively different (docker) networks.
tucano/worker/src/proxy.rs
Line 46 in 18423fe
This works in a "normal" Tucano setup because in this case the worker is in fact the "host" (in the docker networking point of view). When Tucano creates the underlying application container and publishes (to the host) the chosen port, the worker can access it through
127.0.0.1:{port}
.However, when a worker is running through docker (as we're doing in this performance test setup), it isn't the host anymore, not being able to access the underlying application container through
127.0.0.1
anymore.