Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(proto): add the initial rust-based system protocol #5

Merged
merged 4 commits into from
Mar 20, 2024
Merged

feat(proto): add the initial rust-based system protocol #5

merged 4 commits into from
Mar 20, 2024

Conversation

lffg
Copy link
Contributor

@lffg lffg commented Mar 10, 2024

No description provided.

@lffg lffg changed the title Introduce Rust-based protocol defintions refac(protocol): introduce Rust-based protocol defintions Mar 19, 2024
@lffg lffg marked this pull request as ready for review March 20, 2024 01:20
@lffg lffg changed the title refac(protocol): introduce Rust-based protocol defintions feat(proto): add the initial rust-based system protocol Mar 20, 2024
YuriRDev
YuriRDev approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@YuriRDev YuriRDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😛👍🦅🦅🦅🦅🦅

@lffg lffg mentioned this pull request Mar 20, 2024
Merged
gustavodiasag
gustavodiasag approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@gustavodiasag gustavodiasag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bit unsure about NodeName, but that's just nitpicking

@lffg
Copy link
Contributor Author

lffg commented Mar 20, 2024 •
edited
Loading

Just a bit unsure about NodeName, but that's just nitpicking

@gustavodiasag, yeah, I'm still unsure about that too! We may change it later. Our protocol doesn't need to be stable yet so we may change it when we see fit--this is just a starting point. But I digress...

@lffg lffg merged commit b2776bf into main Mar 20, 2024
3 checks passed
@lffg lffg deleted the poc-axum branch March 20, 2024 22:33
@lffg lffg self-assigned this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavodiasag gustavodiasag gustavodiasag approved these changes

@YuriRDev YuriRDev YuriRDev approved these changes

@lemosep lemosep Awaiting requested review from lemosep

Assignees

@lffg lffg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lffg @YuriRDev @gustavodiasag