-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make network processes synchronous #9
Conversation
- Add list of Content Types given file extension - Add function to return Content Type of a path
Friendly bump :) |
Also friedly bump 🐛 |
Thanks for the merge request. I have a couple of questions.
|
Maybe instead of removing |
ping @wynro |
I've merged half of this pull request (1 of 2 commits). I'm still not comfortable committing the mime types as I'd rather just require that information from wherever else it must be defined in Emacs. I don't want to have to maintain a new list of mime types. |
@eschulte Fully agree. I wanted to separate this and pull-request only the second commit but I forgot, sorry. In any case, now that the relevant piece is merged I'll close the pull request |
@eschulte thanks 🎉 |
Elnode doesn't work on Emacs 26.1, because it disallows both the `:nowait` and `:server` parameters. Add a cautious fix for this, which flips `:nowait` to nil when Emacs is on 26.1 upwards. This is the same method used by `emacs-http-server` to fix the same bug. Initial fix: eschulte/emacs-web-server#9 26.1-only patch: eschulte/emacs-web-server@cafa5b7
Elnode doesn't work on Emacs 26.1, because it disallows both the `:nowait` and `:server` parameters. Add a cautious fix for this, which flips `:nowait` to nil when Emacs is on 26.1 upwards. This is the same method used by `emacs-http-server` to fix the same bug. Initial fix: eschulte/emacs-web-server#9 26.1-only patch: eschulte/emacs-web-server@cafa5b7
Given some changes in the Emacs networking code, this change makes the network process synchronous. It is also necessary for the server to work properly.
Extract from the changelog