slightly more assertive puppeteer shutdown instructions

errorcorrectionzoo · Feb 13, 2025 · 85369b6 · 85369b6
1 parent 6a0d4ce
commit 85369b6
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 13 deletions.
diff --git a/_zoodb_citations_cache/cache_compiled_citations.json b/_zoodb_citations_cache/cache_compiled_citations.json
diff --git a/_zoodb_citations_cache/cache_downloaded_info.json b/_zoodb_citations_cache/cache_downloaded_info.json
diff --git a/jscomponents/codegraph/headlessGraphExporter.js b/jscomponents/codegraph/headlessGraphExporter.js
@@ -133,19 +133,30 @@ export class CodeGraphSvgExporter
             await this.browser_code_server.close();
         }
 
-        // Close page.
-        if (this.page != null) {
-            debug(`Shutting down headless puppeteer browser page...`);
-            await this.page.close();
-            this.page = null;
-        }
-
-        // Close browser.
+        // .close() methods appear unreliable.
+        // cf. https://github.com/puppeteer/puppeteer/issues/7922
         if (this.browser != null) {
-            debug(`Shutting down headless puppeteer browser...`);
-            await this.browser.close();
-            this.browser = null;
+            debug(`Bye bye puppeteer browser page...`);
+            const childProcess = this.browser.process()
+            if (childProcess) {
+                childProcess.kill(9)
+            }
         }
+
+        // // Close page.
+        // if (this.page != null) {
+        //     debug(`Shutting down headless puppeteer browser page...`);
+        //     await this.page.close();
+        //     this.page = null;
+        // }
+
+        // // Close browser.
+        // if (this.browser != null) {
+        //     debug(`Shutting down headless puppeteer browser...`);
+        //     await this.browser.close();
+        //     this.browser = null;
+        // }
+
         debug(`Internal headless puppeteer browser instance completely shut down.`);
     }