Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HeroicGOGHandler doesn't check the installed.json file exists before parsing #154

Closed
MistaOmega opened this issue Oct 5, 2024 · 0 comments · Fixed by #155
Closed

HeroicGOGHandler doesn't check the installed.json file exists before parsing #154

MistaOmega opened this issue Oct 5, 2024 · 0 comments · Fixed by #155

Comments

@MistaOmega
Copy link
Contributor

Summary

The HeroicGOGHandler.cs file, line 55 attempts to parse the installed json file, without validating it exists
It may not exist, if the user has installed Heroic, but has not signed into GOG. the folder gog_store can exist, but be empty

Solution

Checking if the file exists before attempting a parse should resolve
This was referenced Oct 5, 2024
Merged
Closed
erri120 added a commit that referenced this issue Oct 6, 2024
@erri120
Merge pull request #155 from MistaOmega/#154-Validate-installed-json-…
8f8f666 
…exists

Validate the installed_json file exists before parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate the installed_json file exists before parsing MistaOmega/GameFinder
1 participant
@MistaOmega