Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action didn't fail for configuration error in .yml files #97

Closed
kayx23 opened this issue May 8, 2023 · 1 comment
Closed

Action didn't fail for configuration error in .yml files #97

kayx23 opened this issue May 8, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@kayx23
Copy link

kayx23 commented May 8, 2023

Noticed reviewdog would pass in the following situations, where I think it should fail.

Example 1

image

image

Link to the action

Example 2

Here I copy pasted the .yml config over and did not notice the incorrect indentation from line 2 and onwards. Reviewdog seems to pass but in reality it errored out:
image

Link to the action

@rmoff
Copy link
Contributor

rmoff commented Oct 2, 2024

Adding another example of this problem. My vale config had the wrong case for a styles folder. The action still returned a success status though.

CleanShot 2024-10-02 at 09 53 14

CleanShot 2024-10-02 at 09 53 03

jdkato added a commit that referenced this issue Oct 9, 2024
#97: Catch Vale runtime errors properly
@jdkato jdkato added the bug Something isn't working label Oct 9, 2024
@jdkato jdkato closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants