Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vale action output showing up under different workflow #73

Closed
heitortsergent opened this issue Jul 11, 2022 · 5 comments · Fixed by #118
Closed

Vale action output showing up under different workflow #73

heitortsergent opened this issue Jul 11, 2022 · 5 comments · Fixed by #118
Labels
bug Something isn't working

Comments

@heitortsergent
Copy link

I'm trying to add the vale-action to the Stoplight docs repository (this PR), and for some reason the reviewdog output with the annotations for the vale-action is being added under another workflow we have in our repo for checking markdown links:

Screen Shot 2022-07-11 at 3 30 50 PM

Any ideas on why that might be happening? I tried removing the markdown-link-check workflow to see what happens, and that makes the reviewdog vale report show up correctly under the vale action.

@erezrokah
Copy link
Contributor

Adding another case of this issue in cloudquery/cloudquery#4413
image

Vale is showing up failed on an unrelated PR Labeler action

@Jan0707
Copy link

Jan0707 commented Dec 1, 2022

I am encountering the same issue. Vale's result do show up in a different action entirely.

fabianrbz added a commit to Kong/docs.konghq.com that referenced this issue Dec 15, 2022
The old value `github-pr-check` was attaching the report to a different
check. See errata-ai/vale-action#73
fabianrbz added a commit to Kong/docs.konghq.com that referenced this issue Dec 15, 2022
The old value `github-pr-check` was attaching the report to a different
check. See errata-ai/vale-action#73
fabianrbz added a commit to Kong/docs.konghq.com that referenced this issue Dec 15, 2022
The old value `github-pr-check` was attaching the report to a different
check. See errata-ai/vale-action#73
fabianrbz added a commit to Kong/docs.konghq.com that referenced this issue Dec 15, 2022
The old value `github-pr-check` was attaching the report to a different
check. See errata-ai/vale-action#73
mheap pushed a commit to Kong/docs.konghq.com that referenced this issue Dec 15, 2022
* Make `vale`, actually `reviewdog` fail on error
* Set vale's reporter to github-pr-review

The old value `github-pr-check` was attaching the report to a different
check. See errata-ai/vale-action#73
vm-001 pushed a commit to Kong/docs.konghq.com that referenced this issue Dec 22, 2022
* Make `vale`, actually `reviewdog` fail on error
* Set vale's reporter to github-pr-review

The old value `github-pr-check` was attaching the report to a different
check. See errata-ai/vale-action#73
cloudjumpercat pushed a commit to Kong/docs.konghq.com that referenced this issue Jan 4, 2023
* Make `vale`, actually `reviewdog` fail on error
* Set vale's reporter to github-pr-review

The old value `github-pr-check` was attaching the report to a different
check. See errata-ai/vale-action#73
@prcr
Copy link

prcr commented Jan 5, 2023

Also happens to me (I had previously opened #57).

@DaemonLoki
Copy link

Encountering a similar issue. Is there any hint on what might cause this, yet?

@heitortsergent
Copy link
Author

Did some digging around, and this seems to be an issue with GitHub Actions and its API, and it's been around for a while now:

https://github.com/orgs/community/discussions/24616

And feedback from more people on the reviewdog project: reviewdog/reviewdog#403

It doesn't seem like this will be fixed anytime soon, so I think it might be better to just close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants