Implement notifications for all messages

[nicolashohm]

Implement option to get notifications also for message not just for mentions

[astorije]

Hi @nickel715, thanks a lot for your contribution!

This seems like a fine PR, I'll take ownership but I'll have to try it out before giving my 👍.

@erming, @JocelynDelalande, @floogulinc, what do we think about this feature overall? To me it doesn't seem like overhead on either the code or the UI, and people might want this anyway.

In the future, I'd like to see all of this dealt by the plugin system (hint hint, help needed on the plugin system!). How we handle with this in details is however TBD.

[floogulinc]

I think if we add this option, it should be able to be toggled on a per channel basis. There are some channels (more private ones) that I would like to be notified for any message, but others, large channels with constant conversation, it would just be spam.

[JocelynDelalande]

Would reword as "notifyAllMessages"

[JocelynDelalande]

Thanks for contrib @nickel715

Read and tested, appart the naming issue I commented in the diff, it's ok for me (dare to fix your PR @nickel715 ?)

Unlike @floogulinc I think this can go as-is into shout. Per-chan toggle could go to another PR if someone wants to code it ; what you suggest is clearly a valid feature @floogulinc .

[floogulinc]

@JocelynDelalande as long as it's an option, and off by default, I'm totally fine adding it as-is. 👍

[floogulinc]

Don't really think we do this. We add the full changelog upon release of a new version.

[nicolashohm]

ok, should i revert the addition in changelog.md?

[floogulinc]

@nickel715 if you're already making a commit for something else, then you could. It's not a big concern.

[nicolashohm]

@JocelynDelalande thanks for review.
I agree with you, per-chan toggle could go to another feature.
Rewording of notifyMessage sounds good, it's more precise. I will change it.

[MaxLeiter]

bump? Would love this

[nicolashohm]

@MaxLeiter thanks for the reminder, now alle comments are fixed :)

[JocelynDelalande]

@nickel715 awesome, thanks :) 👍

@astorije @floogulinc ok for you ?

[JocelynDelalande]

@nickel715 could you just squash your commits into one please ?

[astorije]

Hi @nickel715, thanks again for this!
I am also a 👍 on this but as @JocelynDelalande, I'd like you to squash these 2 commits into 1.
If you are not familiar with the process, follow these steps and be done with it:

1. Checkout to your branch, then run git rebase -i HEAD~2.
2. This will open a text editor and mark the second commit at a fixup (replace pick on the second line with f). Save and exit the editor.
3. Push with git push -f

Once you have done that, comment on this thread so that I get notified, and I'll merge this! It will then ship with the next release, hopefully as soon as possible.

[nicolashohm]

@astorije done. sorry for the delay

[astorije]

Awesome, thanks again!