Fix problems when reading from stdin and "-noshell" was passed to erl (or used through an escript) #7384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 3 files 143 suites 1h 44m 46s ⏱️ For more details on these failures, see this check. Results for commit b572a4c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
This was referenced Jun 9, 2023
frazze-jobb
approved these changes
Jun 14, 2023
2b49f96 to
94927cc
Compare
frazze-jobb
reviewed
Jun 15, 2023
kpy3
reviewed
Jun 15, 2023
Various eof scenarios when group is using io_lib:collect_chars was not handled correctly and thus when "oldshell" was changed to be handled by group it broke some existing usages. fixes erlang#7368 fixes erlang#6881 fixes erlang#7286
61eaa70 to
f776a11
Compare
As group now acts as the proxy when running "oldshell" or "noshell" it needs to be able to read and write raw binaries. Latin1 encoding allows all possible bytes, so by fixing latin1 we allow any bytes to be passed into and out of Erlang unmodified. fixes erlang#7230
305f4ba to
2b1ce5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problems when reading from stdin and "-noshell" was passed to erl (or used through an escript)
fixes #7368
fixes #6881
fixes #7286
fixes #7230