Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#237] Remove eflame #559

Merged
merged 4 commits into from
Mar 14, 2020
Merged

[#237] Remove eflame #559

merged 4 commits into from
Mar 14, 2020

Conversation

robertoaloi
Copy link
Member

Description

We are not going to implement #237 for the time being. Cleaning up the deps, then.

@jfacorro
Copy link
Contributor

elvis_ core 0.6.0 has some API changes when calling elvis_core:rock/N. The configuration is no longer resolved automagically, it now needs to be provided as an argument.

@robertoaloi
Copy link
Member Author

Noticed. Fixing.

@robertoaloi
Copy link
Member Author

The elvis_core documentation was incorrect. Here's a fix for that: inaka/elvis_core#120

@robertoaloi robertoaloi merged commit 6463986 into master Mar 14, 2020
@robertoaloi robertoaloi deleted the 237-remove-eflame branch March 14, 2020 12:43
@dgud
Copy link
Contributor

dgud commented Mar 14, 2020

Hmm now I get problems, what do I need to do, my rebar skills are lacking here.

>make
Building escript...
===> Verifying dependencies...
===> Package elvis_core-0.6.0 not found. Fetching registry updates and trying again...
===> Updating package registry...
===> Writing registry to /home/dgud/.cache/rebar3/hex/default/registry
===> Generating package index...
===> Writing index to /home/dgud/.cache/rebar3/hex/default/packages.idx
===> Package not found in registry: {<<"elvis_core">>,<<"0.6.0">>}.
Makefile:4: recipe for target 'all' failed
make: *** [all] Error 1

@robertoaloi
Copy link
Member Author

robertoaloi commented Mar 14, 2020

@dgud I would start by:

rm -rf _build
rm -rf ~/.cache/rebar3/hex
rebar3 update
`

@dgud
Copy link
Contributor

dgud commented Mar 15, 2020

Thanks.

It didn't work, but that got me questioning the world around me.
Updating rebar3 solved the problem.
From an old 2.6.? to 3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants