Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Elvis Configuration #937

Closed
robertoaloi opened this issue Mar 13, 2021 · 0 comments · Fixed by #938
Closed

Correct Elvis Configuration #937

robertoaloi opened this issue Mar 13, 2021 · 0 comments · Fixed by #938

Comments

@robertoaloi
Copy link
Member

After the conversion of the repository to an umbrella app, the Elvis linter is not configured correctly.

  • Lint all applications
  • Run linter via rebar3 plugin and not as a compiler hook
  • Upgrade linter to latest available version
  • Fix all current linting issues
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
[#937] Fix linting issues in els_core
83826b3
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
[#937] Fix linting issues in els_lsp
b32d251
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
[#937] Fix linting issues in els_dap
08e80c5
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
[#937] Update linter (elvis_core, rebar3_lint), run it via plugin
6a49a52
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
[#937] Upgrade Elvis to latest master, fetch rebar3_lint from Hex, tw…
f1faa76 
…eak rules
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
[#937] Use wildcards for dirs
29670e2
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
[#937] Rename fold_* functions according to convention
5bd9a2c
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
[#937] Do not crash the linter
fbdab04 
Reference: inaka/elvis_core#183
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
[#937] Use stable version of elvis_core since wildcards do not seem t…
eb08679 
…o work anyway
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
[#937] Use stable version of elvis_core since wildcards do not seem t…
69657fd 
…o work anyway
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
[#937] Upgrade linter and correctly apply its configuration
8f87d79 
* Upgrade linter (elvis_core, rebar3_lint)
* Fetch linter from Hex rather than git
* Run linter via its plugin and not as a compiler hook
* Fix current linting issues
* Update Elvis config in test application

Found an elvis_core bug: inaka/elvis_core#183

Not using wildcards for `dirs` in the Elvis config, since they are
still not supported.
@robertoaloi robertoaloi mentioned this issue Mar 13, 2021
Merged
robertoaloi added a commit that referenced this issue Mar 13, 2021
@robertoaloi
Merge pull request #938 from erlang-ls/937-fix-elvis-configuration
e410de2 
[#937] Upgrade linter and correctly apply its configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#937] Upgrade linter and correctly apply its configuration erlang-ls/erlang_ls
1 participant
@robertoaloi