[wip] Why we even need txNum for statesyncTx? Yep. In RPC we needn't it.

[JkLondon]

No description provided.

[Giulio2002]

@AskAlexSharov i am scared of this PR

[AskAlexSharov]

me too. but i don't understand it yet. will dig today.

[AskAlexSharov]

don't understand why need rely on blockNum == 0 if txnLookup returns ok

[AskAlexSharov]

faced some issues on release3.0 branch:

1. External rpcd can't start - because we didn't cherry pick set ready on file open as well as download complete #13901 . doing: cherry-pick: external rpcdaemon can't start #14090
2. On amoy: curl 'http://localhost:8545' -H 'Content-Type: application/json' --data '{"id": 1, "jsonrpc": "2.0", "method": "eth_getLogs", "params": [ {"fromBlock": "14300401","toBlock": "14300501"} ]}' did panic EROR[03-06|03:25:55.613] RPC method eth_getLogs crashed: runtime error: index out of range [0] with length 0 [service.go:223 panic.go:785 panic.go:115 bor_receipts_generator.go:86 eth_receipts.go:306 eth_receipts.go:143 value.go:581 value.go:365 service.go:228 handler.go:534 handler.go:484 handler.go:425 handler.go:245 handler.go:338 asm_amd64.s:1700] - fixed by: nil ptr in gen bor logs #14091 and cherry-pick: nil ptr in gen bor logs  #14092
3. CI get red recently: https://github.com/erigontech/erigon/commits/release/3.0

now can try to test this PR

[AskAlexSharov]

@JkLondon seems i found why 2 works:

• you added unnecessary +1 here https://github.com/erigontech/erigon/pull/12424/files#diff-3ec5d198c216ed6a8bbf81d0ba01606a5ba866a4bc125bca4cc1408a0d1e7c37R50 and here https://github.com/erigontech/erigon/pull/12424/files#diff-72924d5ce1ba1962b50ba71cd48ca3c4ac4c54c1322e7db1bbac2108f760e517R1127
• I think if you remove +1 from that low-level places, then you will not need - 2 (will need - 1 as I expected)

Prototyped here (seems works) https://github.com/erigontech/erigon/compare/bor-txnum-statesync-eradication...bor-txnum-statesync-eradication_dbg?expand=1

[Giulio2002]

ok guys, please let's not merge this yet