Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcdaemon: Don't set miner #13799

Merged
merged 1 commit into from
Feb 13, 2025
Merged

rpcdaemon: Don't set miner #13799

merged 1 commit into from
Feb 13, 2025

Conversation

shohamc1
Copy link
Member

Cherry pick #13795

Fixes incorrect patch for #12690

See:
#12690 (comment)

```
➜  curl --request POST \
  -s --url http://127.0.0.1:8545/ \
  --header 'Content-Type: application/json' \
  --data '{
        "method": "eth_getBlockByHash",
        "params": [
                "latest",
                false
        ],
        "id": 1,
        "jsonrpc": "2.0"
}' | jq '.result.miner'
"0x0000000000000000000000000000000000000000"
➜  curl --request POST \
  -s --url http://127.0.0.1:8545/ \
  --header 'Content-Type: application/json' \
  --data '{
        "method": "eth_getBlockByNumber",
        "params": [
                "latest",
                false
        ],
        "id": 1,
        "jsonrpc": "2.0"
}' | jq '.result.miner'
"0x0000000000000000000000000000000000000000"
```

(cherry picked from commit 702a0d8)
@shohamc1 shohamc1 enabled auto-merge (squash) February 13, 2025 12:50
@yperbasis yperbasis added this to the 2.61.2-fixes milestone Feb 13, 2025
@yperbasis yperbasis disabled auto-merge February 13, 2025 13:18
@yperbasis yperbasis merged commit 156575f into release/2.61 Feb 13, 2025
7 checks passed
@yperbasis yperbasis deleted the shohamc1/pick-13795-e2 branch February 13, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants