Pectra devnet 6 commits to E2 #13718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue reported for `devnet-5` with trace as follows ``` [INFO] [01-29|21:33:12.026] Received GetPayloadV4 payloadId=369 [EROR] [01-29|21:33:12.026] RPC method engine_getPayloadV4 crashed: runtime error: index out of range [0] with length 0 [service.go:223 panic.go:770 panic.go:114 block_building.go:223 execution_client.go:53 engine_server.go:475 engine_api_methods.go:74 value.go:596 value.go:380 service.go:228 handler.go:534 handler.go:484 handler.go:425 handler.go:245 handler.go:338 asm_amd64.s:1695] ```
As per updated specs, this check should preemptively return -32602 See https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md#engine_newpayloadv4
yperbasis
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.