Bug fix pallets#793; use the first defined long name

ericfrederich · May 19, 2017 · 3e4abc1 · 3e4abc1
1 parent 2ab5f7e
commit 3e4abc1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES b/CHANGES
@@ -13,6 +13,7 @@ Version 6.8
 - Fix bug in test runner when calling ``sys.exit`` with ``None``. See #739.
 - Fix crash on Windows console, see #744.
 - Fix bashcompletion on chained commands. See #754.
+- Fix option naming routine to match documentation.  See #793
 
 Version 6.7
 -----------

diff --git a/click/core.py b/click/core.py
@@ -1548,8 +1548,8 @@ def _parse_decls(self, decls, expose_value):
                     opts.append(decl)
 
         if name is None and possible_names:
-            possible_names.sort(key=lambda x: len(x[0]))
-            name = possible_names[-1][1].replace('-', '_').lower()
+            possible_names.sort(key=lambda x: -len(x[0]))  # group long options first
+            name = possible_names[0][1].replace('-', '_').lower()
             if not isidentifier(name):
                 name = None