Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove promise duplication. #117

Merged
merged 1 commit into from
Aug 1, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/Resolver.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ export default class Resolver extends React.Component {
const queue = [];

renderToStaticMarkup(
<Resolver data={initialData} onResolve={(promise) => queue.push(promise)}>
<Resolver data={initialData} onResolve={((promise) => {
queue.push(promise);
return Promise.resolve(true);
})}>
{render}
</Resolver>
);
Expand Down Expand Up @@ -211,9 +214,11 @@ export default class Resolver extends React.Component {

onResolve(state) {
if (this.props.onResolve) {
this.props.onResolve(state);
return this.props.onResolve(state);
} else if (this.context.resolver) {
this.context.resolver.onResolve(state);
return this.context.resolver.onResolve(state);
} else {
return state;
}
}

Expand Down Expand Up @@ -244,7 +249,7 @@ export default class Resolver extends React.Component {

const promises = pending.map(({ promise }) => promise);

const resolving = Promise.all(promises).then(values => {
var resolving = Promise.all(promises).then(values => {
const id = this[ID];
const resolved = values.reduce((resolved, value, i) => {
const { name } = pending[i];
Expand All @@ -258,7 +263,7 @@ export default class Resolver extends React.Component {
});

// Resolve listeners get the current ID + resolved
this.onResolve(resolving);
resolving = this.onResolve(resolving);

// Update current component with new data (on client)
resolving.then(({ resolved }) => {
Expand Down
1 change: 1 addition & 0 deletions src/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export default function client(Loader) {

enqueue(promise) {
this.queue.push(promise);
return promise;
}

render() {
Expand Down