LDAP support #783
Merged
LDAP support #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
0. Maximum parity with upstream code 1. Added Apache-required modification notices 2. Added Apache license
|
I'm going to merge this to simplify work on a different branch that also makes a vendor change. However, feel free to send feedback and I'll make any necessary changes in a follow-up branch. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #779.
This does some very aggressive copying and pasting of Grafana's code and configs --- correctly handling all the different cases for group membership is really finicky and I think the best thing for us to do is just steal their interface (i.e., config format) and implementation entirely. As I understand it, MIT and Apache 2.0 are compatible, so this is unproblematic.
@Mattouille I'd be interested in code review and maybe some additional testing for this if you have time --- you should also feel free to make code changes.