Report global maximum duration only once

[mvorisek]

#657 must be merged first

replaces #379

fixes #643

Now the global maximum duration is still reported, but only once - in the report header. It is now also clearer what the number in the parenthesis means, as the header describes it.

It the items list, only the non-global maximum durations are shown. This makes the non-global maximum duration to stand out visually.

[codecov]

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.76%. Comparing base (27aacf7) to head (115f795).

Files with missing lines	Patch %	Lines
src/Reporter/DefaultReporter.php	94.44%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #396      +/-   ##
============================================
+ Coverage     56.14%   56.76%   +0.62%     
- Complexity      117      119       +2     
============================================
  Files            28       28              
  Lines           675      687      +12     
============================================
+ Hits            379      390      +11     
- Misses          296      297       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[localheinz]

@mvorisek

Can you explain what problem you are trying to solve with this and #379?

[localheinz]

@mvorisek

No, that's #380 - this pull request here and #379 are about changing the output.

[mvorisek]

My apologies.

In this PR I improved the UX of the output. Please see the PR description. It deduplicates the global max. duration value in the output. And as coded newly, the value in the parenthesis now makes more sense in the header, as the header mentions what the value is about. This is also how https://github.com/johnkary/phpunit-speedtrap was/is coded.

[localheinz]

@mvorisek

Perhaps it would make more sense to allow configuring the reporter?

This way everyone can use the reporter (and thus, the format of the report) of their choice.

What do you think?

[mvorisek]

PR is done and rebased on the latest main.

Perhaps it would make more sense to allow configuring the reporter?

Deduplicated/simpler to read report is better for UX. IMHO no configuration option is needed, it would only complicate the code.

[mvorisek]

@localheinz default/native PHPUnit duration formatter always shows minutes - https://github.com/sebastianbergmann/php-timer/blob/6.0.0/src/Duration.php#L81 - I tried to unify the format with this one, but the results were too complex. Then I tried to format times below 1 minute with s/ms and the results are, in my opinion, very readable and the whole output feels very natural. Wdyt?

[mvorisek]

@localheinz this is purely an UX change. I want your green light here in order to rebase. If you, for some reasons, do not want this improvement, please share the reasons with me and we can find a common ground or even close this PR. Thanks!

[localheinz]

Apologies for the delay, @mvorisek - please rebase!