Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure project layout #189

Merged
merged 30 commits into from
Jan 17, 2022
Merged

Restructure project layout #189

merged 30 commits into from
Jan 17, 2022

Conversation

pschafhalter
Copy link
Member

  • Reorganizes project into workspace containing 2 crates (erdos and python).
  • Switches from setuptools_rust to maturin for managing Python distributions.
  • Pin Rust version to nightly-2021-12-04.
  • Remove benchmarks and extra dependencies.
  • Update Dockerfile and CI.

@pschafhalter
Remove benchmarks
9d9aee1
@pschafhalter
Remove benchmarks from Cargo.toml
73ed977
@pschafhalter
Setup workspace and move rust code to new folder
12f5949
@pschafhalter
Set up python sub-crate
fa510c1
@pschafhalter
Move rust/python logic to python crate
6b1dad1
@pschafhalter
Rebase
4d7defc
@pschafhalter
Move python docs dir
f756cf4
@pschafhalter
Set rust toolchain
6e6aad3
@pschafhalter
Update Dockerfile
b7d2a87
@pschafhalter
Update README
d142f51
@pschafhalter
Formatting and remove extra dependencies
0656b20
@pschafhalter
Work on doc
8c20ccf
@pschafhalter
Remove rustfmt.toml
df865a6
@pschafhalter
Update python README
00960aa
@pschafhalter
Fix CI
6b94744
@pschafhalter
Rename rust-toolchain.toml to rust-toolchain
13fc642
@pschafhalter
CI fixes
31a6d10
@pschafhalter
Update CI
0572b55
@pschafhalter
Update docs CI build
b3bffdc
@pschafhalter
Fix CI python formatting
5b01ce7
@pschafhalter
try to make pythondoc fail
dba9c47
@pschafhalter
Fix lib naming collision
dc1e1d0
@pschafhalter
Add numpy dependency
ecf592f
@pschafhalter
Try to make python doc CI fail
29dc078
@pschafhalter
Formatting
ac76fa7
@pschafhalter
Fix yapf version
57adc67
@pschafhalter
Fix python CI and update README
e29318e
ICGog
ICGog reviewed Jan 16, 2022
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
ICGog
ICGog reviewed Jan 16, 2022
View reviewed changes
Copy link
Contributor

@ICGog ICGog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

sukritkalra
sukritkalra requested changes Jan 16, 2022
View reviewed changes
.github/workflows/ci.yaml Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
README.md Show resolved Hide resolved
sukritkalra
sukritkalra approved these changes Jan 17, 2022
View reviewed changes
Copy link
Collaborator

@sukritkalra sukritkalra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing the minor comments!

@pschafhalter pschafhalter merged commit 47939ac into erdos-project:redesign Jan 17, 2022
@pschafhalter pschafhalter deleted the restructure branch January 17, 2022 06:36
@sukritkalra sukritkalra mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ICGog ICGog ICGog left review comments

@sukritkalra sukritkalra sukritkalra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pschafhalter @ICGog @sukritkalra